id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
5003	The anti-cache timestamp is not applied on a few critical files.	Niek Kouwenberg		"I've recently had some trouble with clients getting Javascript errors after I've updated CKEditor to 3.0.2. Now with 3.1, I don't want the same trouble, so I investigated the anti-cache functionality.

I include the CKEditor in the proper way, and most files do get the anti-cache timestamp, but a few critical ones don't. The two criticals I have had problems with are custom plugins, and skins.



'''Timestamp ommited when loading a custom plugin'''

I have a custom plugin for CKEditor, which I used to include like below.
{{{
CKEDITOR.plugins.addExternal('myplugin', 'ckeditor/plugins/myplugin/');
}}}

You can see I ommited the filename, making it default to 'plugin.js'. However, doing so, the anti-cache timestamp is not appended to the file name.
When I define the filename like blow, the timestamp IS added.
{{{
CKEDITOR.plugins.addExternal('myplugin', 'ckeditor/plugins/myplugin/', 'plugin.js');
}}}

I reckon the timestamp should also be appended when using a 'default' filename, not only when I define it manually.


'''Timestamp not appended to my skin'''

The anti-cache timestamp is never appended to the skin filename. Even if I use one of the three CKEditor skins, or use my own custom skin, no timestamp appended.

In core/skins.js on line 197, you can see the following code:
{{{
CKEDITOR.scriptLoader.load( skinPath + 'skin.js', function()
{
	loadPart( editor, skinName, skinPart, callback );
});
}}}

No timestamp, whereas a simple change can solve the caching problems:
{{{
CKEDITOR.scriptLoader.load( skinPath + 'skin.js?t=' + CKEDITOR.timestamp, function()
}}}








"	Bug	closed	Normal		General	3.1	duplicate