Opened 7 years ago

Closed 7 years ago

#5261 closed Bug (fixed)

scayt_autoStartup slow down editor loading

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.3
Component: UI : Spell Checker Version: SVN (CKEditor) - OLD
Keywords: Firefox Confirmed Review+ Cc: WebSpellChecker.net

Description

Loading SCAYT on startup could somehow compromise all the efforts we've done to accelerate loading performance, where the SCAYT engine file (~100K) is blocking our theme file in execution order, which in turn made the editor loading significant slower (6x) than it should.
This could at least be confirmed on Firefox and Opera where DOM script loading is sequence sensitive.

Attachments (1)

5261.patch (489 bytes) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by Garry Yao

Attachment: 5261.patch added

comment:1 Changed 7 years ago by Garry Yao

Keywords: HasPatch added

Could SpellChecker.net evaluate if this simple fix is OK or could otherwise compromise SCAYT?

comment:2 Changed 7 years ago by WebSpellChecker.net

This fix is Ok in spite of makes the SCAYT a little bit slowly.

comment:3 in reply to:  2 Changed 7 years ago by Garry Yao

Replying to SpellChecker.net:

This fix is Ok in spite of makes the SCAYT a little bit slowly.

Well, considering the availability of SCAYT is based on the editor instance, I highly recommend taking editor loading time into SCAYT performance consideration.

comment:4 Changed 7 years ago by WebSpellChecker.net

While we review ways to improve the SCAYT load performance we see that the solution proposed can be used to improve editor performance without affecting SCAYT functionality.

comment:5 Changed 7 years ago by Garry Yao

Keywords: Confirmed Review? added; HasPatch removed
Owner: set to Garry Yao
Status: newassigned

comment:6 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:7 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [5328].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy