Opened 7 years ago

Closed 7 years ago

#6508 closed Bug (fixed)

BiDi: Margin mirroring logic doesn't honor CSS direction

Reported by: Tobiasz Cudnik Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.4.2
Component: General Version:
Keywords: Cc:

Description

This is a small fix.

Margin mirroring logic doesn't honor CSS direction set for an element, dom.element#getDirection method should be used by it instead.

Attachments (1)

6508.patch (627 bytes) - added by Tobiasz Cudnik 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by Tobiasz Cudnik

Attachment: 6508.patch added

comment:1 Changed 7 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: newreview

comment:2 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

That could be a micro-change though.

comment:3 in reply to:  2 Changed 7 years ago by Frederico Caldeira Knabben

Replying to Saare:

That could be a micro-change though.

I don't think so... even if small, it's a logic change, so it needs review.

comment:4 Changed 7 years ago by Tobiasz Cudnik

Resolution: fixed
Status: review_passedclosed

Fixed with [5996].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy