Opened 13 years ago
Closed 13 years ago
#7321 closed Bug (fixed)
IE6: Right borders missing in dialog textfields in RTL languages
| Reported by: | James Cunningham | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.6.1 |
| Component: | UI : Dialogs | Version: | 3.0 |
| Keywords: | IBM IE6 | Cc: | Damian, Satya Minnekanti, Teresa Monahan |
Description
Steps to reproduce the defect:
- Open the languages sample in IE6.
- Select a RTL language i.e. Arabic/Hebrew.
- Open the Table dialog.
- Click on the Advanced tab.
Result: See that the right border of the Style textfield is missing.
- Click into any of the other textfields & type some text.
Result: See that the right border is missing after entering text into a textfield (see screenshot).
- Click on the Table Properties tab.
Result: See that most of the right borders are missing.
Attachments (8)
Change History (24)
Changed 13 years ago by
| Attachment: | border missing issue.jpg added |
|---|
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
| Status: | new → confirmed |
|---|---|
| Version: | 3.5.3 (SVN - trunk) → 3.0 |
Occurs in all dialogs since v3.0 in RTL languages
comment:3 Changed 13 years ago by
| Owner: | set to Sa'ar Zac Elias |
|---|---|
| Status: | confirmed → assigned |
Changed 13 years ago by
| Attachment: | 7321.patch added |
|---|
comment:4 Changed 13 years ago by
| Status: | assigned → review |
|---|
comment:5 Changed 13 years ago by
| Status: | review → review_failed |
|---|
I see no changes after patch.
Btw, this issue (very similar, actually) can be verified with IE9+Quirks also.
comment:6 Changed 13 years ago by
| Status: | review_failed → review_passed |
|---|
Ops... I did something wrong. Nice job!
comment:7 Changed 13 years ago by
| Milestone: | → CKEditor 3.6.1 |
|---|
comment:8 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [6937].
comment:9 follow-up: 10 Changed 13 years ago by
I could still see the borders missing on nightly build. Please re open the ticket. i have attached a screenshot.
Changed 13 years ago by
| Attachment: | borders missing.jpg added |
|---|
comment:10 Changed 13 years ago by
comment:11 Changed 13 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Changed 13 years ago by
| Attachment: | 7321_2.patch added |
|---|
comment:12 Changed 13 years ago by
| Owner: | changed from Sa'ar Zac Elias to Garry Yao |
|---|---|
| Status: | reopened → review |
comment:13 Changed 13 years ago by
Though not 100% related with the original TC, I still see some problems in IE6:
- in the Image dialog in LTR language (right borders are missing)
- in RTL mode, Image dialog, in the "Advanced" tab (left border is missing)
Changed 13 years ago by
| Attachment: | ckeditor_borders_rtl.png added |
|---|
Changed 13 years ago by
| Attachment: | ckeditor_borders.png added |
|---|
Changed 13 years ago by
| Attachment: | 7321_3.patch added |
|---|
Changed 13 years ago by
| Attachment: | ckeditor_ie8_quirks_patch3.png added |
|---|
comment:14 Changed 13 years ago by
The third patch caused that IE8 in Quirks mode not does not render input fields correctly in LTR mode (they used to take all the available space, now it looks less nice).
If I had to choose whether to:
- render borders for all fields in IE6 (with 7321_3.patch) for the price of shortening significantly input fields in LTR mode
- or live with the issue that I described for LTR language (right border is mising in IE6) while keeping current length of input elements,
I'd choose the second option. In other words, the third patch is not right imho, the Image dialog should not look like in the image below:
If there's no way to fix the things that I mentioned, let's just focus on the original TC and stay with the second patch.
comment:15 Changed 13 years ago by
| Status: | review → review_passed |
|---|
Ok.. r+ for the 7321_2.patch.. it's ugly though :/
comment:16 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [7031].
This issue is also present in IE7 Quirks mode and IE8 Quirks mode.