id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
9255	Styles.js - should it stay in the root folder?	Wiktor Walc		"`styles.js` looks to me like a leftover from FCKeditor for which we did not find a better place.

'''What's exactly the problem with this file?''' 

It contains sample data used exclusively by two optional plugins (if I'm correct): stylescombo and div. In fact the default `styles.js` does not contain even a single sample for the div dialog, so it's just a sample file for the ""Styles"" combo. 

If `styles.js` is not an essential part of core, it should be rather located in the plugin folder.

'''Proposed solution:'''
 1. Move styles.js into the folder of stylescombo plugin.
 2. The default value for stylesSet should be empty. Eventually it could be overwritten by the stylescombo plugin, because only then styles.js will be available. There is a hardcoded path to `CKEDITOR.getUrl( 'styles.js' )` somewhere in core/styles.js.
 3. To make user's life easier, we can eventually move 'styles.js' into the root folder (using a special directive in the manifest file) of CKEditor, but only if the ""stylescombo"" plugin is included in the release.

Point (3) leads to some additional problems:
 4. If we go ahead with (3) why the templates plugin should be different? To specify the teplate one have to go into the templates' plugin folder.
 5. If we go ahead with (3) we will have different paths to styles.js in development, source and release modes.

'''Last word regarding core...'''

Comments in `core/styles.js` mention the ""Styles"" combo. It's quite unclear where does it come from if we treat plugins as separate things. I believe  comments must be corrected as well to clearly specify which plugin provides it and how it is used.
"	Task	closed	Normal		Core : Styles	4.0	fixed	Discussion