Opened 7 years ago

Closed 7 years ago

#9384 closed Bug (fixed)

[Webkit] Filler char should be treated as bogus node

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6.5
Component: General Version: 3.6.5
Keywords: Cc:

Description

The filler char we created for selecting an empty paragraph in webkit, is corrupting range::checkStartOfBlock/range::checkBoundaryOfElement, it can be verified by the ticket tcs.

Attachments (2)

9384.patch (840 bytes) - added by Garry Yao 7 years ago.
9384_2.patch (2.5 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by Garry Yao

Attachment: 9384.patch added

comment:1 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: newreview

Opened t/9384 on test to justify the ticket issue.

comment:2 Changed 7 years ago by Garry Yao

I've created a standalone ticket TC to justify the bug. http://v3.ckeditor.t/tt/9384/1.html

comment:3 Changed 7 years ago by Garry Yao

Status: reviewassigned

Changed 7 years ago by Garry Yao

Attachment: 9384_2.patch added

comment:4 Changed 7 years ago by Garry Yao

Status: assignedreview

It looks like a more appropriate fix, is instead to treat the filler like a whitespace, so it has a wider impact range.

comment:5 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

The new patch sounded very nice to me as well, but these are the test results I'm having now, with t/9384@tests:
CKTester Fort (8 failed / 727 passed) - 01m 26s 225ms - 100%

Version 0, edited 7 years ago by Frederico Caldeira Knabben (next)

comment:6 Changed 7 years ago by Garry Yao

The review is to be conducted at #9386.

comment:7 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_failedclosed

Fixed with [7625].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy