[Opera] Selection is expanded up to the next element after applying one of basic styles

[Piotrek Koszuliński]

1. Save and open attached sample.
2. Select "[test te]st test test."
3. Press bold 3 times.

• Expected: bold applied, bold removed, bold applied - 3x for the same selection.
• Actual: For the third time selection expands to the start of <u> element.

[Piotrek Koszuliński]

First bad commit: ​https://github.com/ckeditor/ckeditor-dev/commit/feb2952

[Piotrek Koszuliński]

This issue was introduced by ​https://github.com/ckeditor/ckeditor-dev/commit/feb2952, but it was fixed by ​https://github.com/ckeditor/ckeditor-dev/commit/e618e8c few days before. And that's the one which parts were reverted in feb2952.

What's more - 2 minutes before e618e8c on ​https://github.com/ckeditor/ckeditor-dev/commit/6a707b6 issue was introduced for the first time.

History:

• ​https://github.com/ckeditor/ckeditor-dev/commit/6a707b6 introduced issue.
• ​https://github.com/ckeditor/ckeditor-dev/commit/e618e8c fixed issue.
• ​https://github.com/ckeditor/ckeditor-dev/commit/feb2952 reintroduced issue.

[Piotrek Koszuliński]

It looks like we have similar (but occurring less often) issue on v3 (from 3.0). I was able to find a ticket #6874 which says that it's Opera's issue.

However, there's a difference in behaviour between v3 and v4. Much probably there are two overlapping issues.

[Piotrek Koszuliński]

After additional tests I'm pretty sure that there's no other issue, but the original #6874 just happens more often after commits listed in comment:2. So target of this issue should be to revert to previous state of occurrence frequency.

[Garry Yao]

Opened t/9447 to revert part of ​6a707b6 on Opera.

[Piotrek Koszuliński]

I pushed style fixes to be squashed into main commit.

[Garry Yao]

Masterised with:

​https://github.com/ckeditor/ckeditor-dev/commit/3c218b4137e7774b61d0c4687f7ab7d83e2a4b37

[Piotrek Koszuliński]

I masterised also style fixes you forgot to squash.

[Garry Yao]

The original fix in comment:10 is reverted because of #9468.

[Garry Yao]

I found another simple fix to this issue, which fix also #6874, it's safe change to be landed on master.

​https://github.com/ckeditor/ckeditor-dev/commit/9b921f74229f0d946417c7d5bc5f501d5135c2d4

[Piotrek Koszuliński]

Please fix coding style in 9b921f74. Update for #6874 will be needed too (however we still need it for v3).

[Garry Yao]

Coding style fixed...I would port this change to v3 on #6874.