id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
9476	CKEDITOR.dialog#disableButton not working	Jeff Fournier		"It is still possible to click on a dialog button after having disabling it with the disableButton method in CKEDITOR.dialog  (http://docs.cksource.com/ckeditor_api/symbols/CKEDITOR.dialog.html#disableButton).

When ""disableButton"" is called, the property ""disabled"" is correctly set to true and a css class is added to the button. But if you click on the button, there's no check to see if it's disabled and the event is still fired.

I think this could be fixed by modifying the code in _source/plugin/dialogui/plugin.js and adding a check for disabled before the onClick is applied.

Like this :

(line 949)

{{{
onClick : function( dialog, func )
{
    this.on( 'click', function()
    {
        if(!this._.disabled)
        {
            // Some browsers (Chrome, IE8, IE7 compat mode) don't move
            // focus to clicked button. Force this.
            this.getElement().focus();
            func.apply( this, arguments );
        }
    });
}
}}}


By the way, the css class (cke_disabled) added to the button when it's disabled does nothing and the button doesn't look disabled.
"	Bug	confirmed	Normal		General	3.0		HasPatch