Opened 11 years ago
Closed 11 years ago
#9509 closed Bug (fixed)
magicline doesn't work with forms
| Reported by: | Jakub Ś | Owned by: | Olek Nowodziński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.0.1 |
| Component: | General | Version: | 4.0 |
| Keywords: | Cc: |
Description (last modified by )
To reproduce:
- Open any sample and clear editor contents using New Page button
- Insert Form (best in enter_BR as this shows the problem in full )
Result: There is no way to insert line above editor or below it (only in Enter_BR #9509). Magic line doesn't show up.
Change History (10)
comment:1 Changed 11 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 11 years ago by
| Description: | modified (diff) |
|---|
comment:3 Changed 11 years ago by
| Milestone: | → CKEditor 4.0.1 |
|---|
comment:5 Changed 11 years ago by
| Owner: | set to Olek Nowodziński |
|---|---|
| Status: | confirmed → assigned |
comment:6 Changed 11 years ago by
| Status: | assigned → review |
|---|
Created branch t/9509@cksource.
Also added support for blockquote (same issue).
comment:7 follow-up: 8 Changed 11 years ago by
| Status: | review → review_failed |
|---|
Two issues:
- https://github.com/cksource/ckeditor-dev/commit/e9c2abcdccbfa9ea981fd9dcf36fdf0d16bf0b57#L0R39 -
|| falseseems to be superfluous. - some tests would be cool?
comment:8 Changed 11 years ago by
| Status: | review_failed → review |
|---|
Replying to Reinmar:
Two issues:
- https://github.com/cksource/ckeditor-dev/commit/e9c2abcdccbfa9ea981fd9dcf36fdf0d16bf0b57#L0R39 -
|| falseseems to be superfluous.
Fixed.
- some tests would be cool?
Tests don't make any sense since line triggers are defined as follows and they never change. There's not much to do here.
comment:9 Changed 11 years ago by
| Status: | review → review_passed |
|---|
comment:10 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Masterised git:c65eab0
Note: See
TracTickets for help on using
tickets.
Note: this is only v4 issue.