Opened 8 years ago

Closed 8 years ago

#9609 closed Bug (fixed)

JavaScript error when inserting new column in the table

Reported by: Piotrek Koszuliński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.0
Component: General Version: 4.0
Keywords: Cc:

Description

V4's version of ticket which we had in v3: #8295.

Insert the following code:

<table border="1" cellpadding="1" cellspacing="1" style="width: 500px;">
	<tbody>
		<tr>
			<td>
				1.1</td>
			<td>
				1.2</td>
		</tr>
		<tr>
			<td>
				2.1</td>
			<td>
				2.2</td>
		</tr>
		<tr>
			<td>
				3.1</td>
			<td>
				3.2</td>
		</tr>
	</tbody>
</table>

Go to cell 1.2, right click and choose Cell->Insert Cell Before.

Keep cursor in cell 1.2 right click and choose Column->Insert Column Before/After.

Issue: JS error is thrown and error message: 'colSpan' is null or not an object.

Attachments (1)

9609.html (1.7 KB) - added by Olek Nowodziński 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: newassigned

comment:2 Changed 8 years ago by Garry Yao

Owner: changed from Olek Nowodziński to Garry Yao

comment:3 Changed 8 years ago by Olek Nowodziński

Owner: changed from Garry Yao to Olek Nowodziński
  • Created branches t/9609@cksource and t/9609@tests-v4.
  • Ported v3 solution with test cases.

I'm a little bit concerned about the expected behavior of "insert column before" for the following case:

+-----+------+
| 1.1 | 1.2^ |
+-----+------+
| 2.1 |
+-----+

How it works now:

+-----+--------+------+
| 1.1 | &nbsp; | 1.2^ |
+-----+--------+------+
| 2.1 |
+-----+

How it should look like in my opition:

+-----+--------+------+
| 1.1 | &nbsp; | 1.2^ |
+-----+--------+------+
| 2.1 | &nbsp; |
+-----+--------+

Most likely this is not an issue but it brings some confusion. Maybe this is a good moment to re-think this behavior.

Version 0, edited 8 years ago by Olek Nowodziński (next)

comment:4 Changed 8 years ago by Olek Nowodziński

Status: assignedreview

Changed 8 years ago by Olek Nowodziński

Attachment: 9609.html added

comment:5 Changed 8 years ago by Garry Yao

Status: reviewreview_passed

comment:6 Changed 8 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy