Opened 8 years ago

Closed 8 years ago

#9610 closed Bug (fixed)

Focus style for various UI elements is nearly invisible

Reported by: Piotrek Koszuliński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.0
Component: UI : Skins Version: 4.0
Keywords: Cc:

Description (last modified by Piotrek Koszuliński)

  1. Smileys.
  2. Dialog buttons.
  3. Special chars. Focus isn't well visible too. What's more - tab key navigation seems to be broken in this dialog, but this is a separate issue (#9611).

Attachments (1)

Selection_026.png (33.3 KB) - added by Piotrek Koszuliński 8 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by Piotrek Koszuliński

Description: modified (diff)

comment:2 Changed 8 years ago by Piotrek Koszuliński

On FF focus style looks a lot better, because there's a dark border. My report was mainly about Chrome (and other browsers which render this kind of style).

PS. On V3 focus results in the same style as hover.

Version 0, edited 8 years ago by Piotrek Koszuliński (next)

comment:3 Changed 8 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: newassigned

Changed 8 years ago by Piotrek Koszuliński

Attachment: Selection_026.png added

comment:4 Changed 8 years ago by Olek Nowodziński

Created t/9610@cksource branch with better, unified smiley/customchar look and improved dialog button :focus/:active styles.

comment:5 Changed 8 years ago by Olek Nowodziński

Status: assignedreview

comment:6 Changed 8 years ago by Piotrek Koszuliński

Status: reviewreview_failed

I like icons style, but focus style of buttons is too heavy.

comment:7 in reply to:  6 Changed 8 years ago by Olek Nowodziński

Status: review_failedreview

Replying to Reinmar:

I like icons style, but focus style of buttons is too heavy.

Pushed a commit. They're slightly brighter now.

comment:8 Changed 8 years ago by Piotrek Koszuliński

Status: reviewreview_passed

comment:9 Changed 8 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2020 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy