Changeset 4179

Timestamp:

09/02/09 14:36:05 (4 years ago)

Author:

tobiasz.cudnik

Message:

Fixed #3897 - There should be no image previews when the URL is empty in image dialog.

Location:

CKEditor/trunk

Files:

• CHANGES.html (modified) (1 diff)
• _source/plugins/image/dialogs/image.js (modified) (3 diffs)

CKEditor/trunk/CHANGES.html

@@ -60 +60 @@
                 <li><a href="http://dev.fckeditor.net/ticket/4262">#4262</a> : Tab and Shift+Tab was not working to cycle through CTRL+SHIFT+F10 context menu in IE.</li>
                 <li><a href="http://dev.fckeditor.net/ticket/3633">#3633</a> : Default context menu isn't disabled in toolbar, status bar, panels...</li>
+                <li><a href="http://dev.fckeditor.net/ticket/3897">#3897</a> : Now there is no image previews when the URL is empty in image dialog.</li>
         </ul>
         <h3>

CKEditor/trunk/_source/plugins/image/dialogs/image.js

@@ -258 +258 @@
                                         // Refresh LockRatio button
                                         switchLockRatio ( this, true );
+                                }
+
+                                // Dont show preview if no URL given.
+                                if ( !CKEDITOR.tools.trim( this.getValueOf( 'info', 'txtUrl' ) ) )
+                                {
+                                        this.preview.removeAttribute( 'src' );
+                                        this.preview.setStyle( 'display', 'none' );
                                 }
                         },
@@ -404 +411 @@
                                                                                                         var original = dialog.originalElement;
 
+                                                                                                        dialog.preview.removeStyle( 'display' );
+
                                                                                                         original.setCustomData( 'isReady', 'false' );
                                                                                                         // Show loader
@@ -417 +426 @@
 
                                                                                                         updatePreview( dialog );
+                                                                                                }
+                                                                                                // Dont show preview if no URL given.
+                                                                                                else if ( dialog.preview )
+                                                                                                {
+                                                                                                        dialog.preview.removeAttribute( 'src' );
+                                                                                                        dialog.preview.setStyle( 'display', 'none' );
                                                                                                 }
                                                                                         },