Ticket #3897 (closed Bug: fixed)
There should be no image previews when the URL is empty in image dialog
| Reported by: | martinkou | Owned by: | tobiasz.cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.1 |
| Component: | UI : Dialogs | Version: | SVN (CKEditor) - OLD |
| Keywords: | Oracle Confirmed Review+ | Cc: | Senthil |
Description
To reproduce:
- Open replacebyclass sample in IE.
- Open the image dialog.
- Even before any URL is filled into the dialog box, we're still having a cross symbol in the preview pane.
Or, alternatively
- Open replacebyclass sample in any browser.
- Open the image dialog.
- Fill in any URL and defocus the URL text box.
- Remove the URL
- The image is still in the preview pane - it should be cleared instead.
Attachments
Change History
comment:3 Changed 4 years ago by tobiasz.cudnik
- Owner changed from martinkou to tobiasz.cudnik
- Status changed from new to assigned
comment:5 Changed 4 years ago by garry.yao
- Keywords Review- added; Review? removed
It doesn't work for IE.
comment:6 Changed 4 years ago by tobiasz.cudnik
- Keywords Review? added; Review- removed
Seem that setAttribute( 'name', null ) doesn't work like removeAttribute( 'name' ) in IE, while doing so in other browsers.
comment:7 Changed 4 years ago by garry.yao
How about using the below codes after #3898's fix?
if( this.getContentElement( 'info', 'txtUrl' ).validate() != true ) // instead of if ( !CKEDITOR.tools.trim( this.getValueOf( 'info', 'txtUrl' ) ) )
comment:9 Changed 4 years ago by tobiasz.cudnik
Using validate() doesn't work for first dialog show, while getValueOf() is not affected. I will check why that is happening.
comment:10 Changed 4 years ago by tobiasz.cudnik
- Keywords Review? added; Review- removed
After updating dialog file to newer revision it indeed works. Attaching new patch.
comment:11 Changed 4 years ago by garry.yao
- Keywords Review+ added; Review? removed
R+ for 3897_2, 3897_3 instead will bring a validation alert which is not acceptable.
comment:12 Changed 4 years ago by tobiasz.cudnik
- Status changed from assigned to closed
- Resolution set to fixed
Fixed with [4179].
In future will can use 3897_3.patch, when dialog validation system will allow for it.
Note: See
TracTickets for help on using
tickets.
