Opened 16 years ago
Closed 16 years ago
#3897 closed Bug (fixed)
There should be no image previews when the URL is empty in image dialog
| Reported by: | Martin Kou | Owned by: | Tobiasz Cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.1 |
| Component: | UI : Dialogs | Version: | SVN (CKEditor) - OLD |
| Keywords: | Oracle Confirmed Review+ | Cc: | Senthil |
Description
To reproduce:
- Open replacebyclass sample in IE.
- Open the image dialog.
- Even before any URL is filled into the dialog box, we're still having a cross symbol in the preview pane.
Or, alternatively
- Open replacebyclass sample in any browser.
- Open the image dialog.
- Fill in any URL and defocus the URL text box.
- Remove the URL
- The image is still in the preview pane - it should be cleared instead.
Attachments (3)
Change History (15)
comment:1 Changed 16 years ago by
| Cc: | Senthil added |
|---|---|
| Keywords: | Oracle added |
comment:2 Changed 16 years ago by
| Milestone: | CKEditor 3.0 → CKEditor 3.1 |
|---|
comment:3 Changed 16 years ago by
| Owner: | changed from Martin Kou to Tobiasz Cudnik |
|---|---|
| Status: | new → assigned |
Changed 16 years ago by
| Attachment: | 3897.patch added |
|---|
comment:4 Changed 16 years ago by
| Keywords: | Review? Confirmed added |
|---|
comment:5 Changed 16 years ago by
| Keywords: | Review- added; Review? removed |
|---|
Changed 16 years ago by
| Attachment: | 3897_2.patch added |
|---|
comment:6 Changed 16 years ago by
| Keywords: | Review? added; Review- removed |
|---|
Seem that setAttribute( 'name', null ) doesn't work like removeAttribute( 'name' ) in IE, while doing so in other browsers.
comment:7 Changed 16 years ago by
How about using the below codes after #3898's fix?
if( this.getContentElement( 'info', 'txtUrl' ).validate() != true ) // instead of if ( !CKEDITOR.tools.trim( this.getValueOf( 'info', 'txtUrl' ) ) )
comment:8 Changed 16 years ago by
| Keywords: | Review- added; Review? removed |
|---|
comment:9 Changed 16 years ago by
Using validate() doesn't work for first dialog show, while getValueOf() is not affected. I will check why that is happening.
Changed 16 years ago by
| Attachment: | 3897_3.patch added |
|---|
comment:10 Changed 16 years ago by
| Keywords: | Review? added; Review- removed |
|---|
After updating dialog file to newer revision it indeed works. Attaching new patch.
comment:11 Changed 16 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
R+ for 3897_2, 3897_3 instead will bring a validation alert which is not acceptable.
comment:12 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixed with [4179].
In future will can use 3897_3.patch, when dialog validation system will allow for it.

It doesn't work for IE.