Opened 15 years ago
Closed 15 years ago
#3898 closed Bug (fixed)
Add validation checks to image properties dialog.
| Reported by: | Martin Kou | Owned by: | Tobiasz Cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.1 |
| Component: | UI : Dialogs | Version: | SVN (CKEditor) - OLD |
| Keywords: | Oracle Confirmed Review+ | Cc: | Senthil |
Description
To reproduce:
- Open the image dialog.
- Press OK.
An image with no src is created. This is not really a critical issue, but it's reasonable to have some validation there.
Attachments (3)
Change History (13)
comment:1 Changed 15 years ago by
| Milestone: | CKEditor 3.0 → CKEditor 3.1 |
|---|
comment:2 Changed 15 years ago by
comment:3 Changed 15 years ago by
| Owner: | changed from Martin Kou to Tobiasz Cudnik |
|---|---|
| Status: | new → assigned |
Changed 15 years ago by
| Attachment: | 3898.patch added |
|---|
comment:4 Changed 15 years ago by
| Keywords: | Confirmed Review? added |
|---|
comment:5 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
We've already have validation system for dialog, please check link dialog for using it.
comment:6 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
Thanks for the hint, second patch uses validate() method from dialog system.
Changed 15 years ago by
| Attachment: | 3898_2.patch added |
|---|
comment:7 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
My fault, link dialog isn't an decent example for it, the validation is as simple as :
validate : CKEDITOR.dialog.validate.notEmpty( editor.lang.image.urlMissing )
Changed 15 years ago by
| Attachment: | 3898_3.patch added |
|---|
comment:8 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
Will memorize this one for the future.
comment:9 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
Please correct the changelog position when committing.
Note: See
TracTickets for help on using
tickets.
#4004 has been marked as DUP.