Changeset 6296

Timestamp:

01/06/11 09:32:02 (2 years ago)

Author:

alfonsoml

Message:

#5522 old IE doesn't apply type=text for text fields

Location:

CKEditor/trunk

Files:

• CHANGES.html (modified) (1 diff)
• _source/plugins/forms/plugin.js (modified) (4 diffs)

CKEditor/trunk/CHANGES.html

@@ -75 +75 @@
                 <li><a href="http://dev.ckeditor.com/ticket/5930">#5930</a> : [IE] Style definitions are no longer lowercased.</li>
                 <li><a href="http://dev.ckeditor.com/ticket/5361">#5361</a> : Preview window's title should reflect the title tag in full page mode.</li>
+                <li><a href="http://dev.ckeditor.com/ticket/5522">#5522</a> : [IE] In versions &lt; 8 or compatibility mode, type="text" was missing in text fields.</li>
         </ul>
         <h3>

CKEditor/trunk/_source/plugins/forms/plugin.js

@@ -150 +150 @@
                                                 if ( name == 'input' )
                                                 {
-                                                        var type = element.getAttribute( 'type' );
-
-                                                        if ( type == 'text' || type == 'password' )
-                                                                return { textfield : CKEDITOR.TRISTATE_OFF };
-
-                                                        if ( type == 'button' || type == 'submit' || type == 'reset' )
-                                                                return { button : CKEDITOR.TRISTATE_OFF };
-
-                                                        if ( type == 'checkbox' )
-                                                                return { checkbox : CKEDITOR.TRISTATE_OFF };
-
-                                                        if ( type == 'radio' )
-                                                                return { radio : CKEDITOR.TRISTATE_OFF };
-
-                                                        if ( type == 'image' )
-                                                                return { imagebutton : CKEDITOR.TRISTATE_OFF };
+                                                        switch( element.getAttribute( 'type' ) )
+                                                        {
+                                                                case 'button' :
+                                                                case 'submit' :
+                                                                case 'reset' :
+                                                                        return { button : CKEDITOR.TRISTATE_OFF };
+
+                                                                case 'checkbox' :
+                                                                        return { checkbox : CKEDITOR.TRISTATE_OFF };
+
+                                                                case 'radio' :
+                                                                        return { radio : CKEDITOR.TRISTATE_OFF };
+
+                                                                case 'image' :
+                                                                        return { imagebutton : CKEDITOR.TRISTATE_OFF };
+
+                                                                default :
+                                                                        return { textfield : CKEDITOR.TRISTATE_OFF };
+                                                        }
                                                 }
 
@@ -188 +191 @@
                                 else if ( element.is( 'input' ) )
                                 {
-                                        var type = element.getAttribute( 'type' );
-
-                                        switch ( type )
-                                        {
-                                                case 'text' :
-                                                case 'password' :
-                                                        evt.data.dialog = 'textfield';
-                                                        break;
+                                        switch ( element.getAttribute( 'type' ) )
+                                        {
                                                 case 'button' :
                                                 case 'submit' :
@@ -209 +206 @@
                                                 case 'image' :
                                                         evt.data.dialog = 'imagebutton';
+                                                        break;
+                                                default :
+                                                        evt.data.dialog = 'textfield';
                                                         break;
                                         }
@@ -232 +232 @@
                                                 var attrs = input.attributes,
                                                         type = attrs.type;
+                                                // Old IEs don't provide type for Text inputs #5522
+                                                if ( !type )
+                                                        attrs.type = 'text';
                                                 if ( type == 'checkbox' || type == 'radio' )
                                                         attrs.value == 'on' && delete attrs.value;