Changeset 6303

Timestamp:

01/11/11 15:25:52 (2 years ago)

Author:

garry.yao

Message:

#6390: dialog cover displays before loading to prevent from invalid clicks.

Location:

CKEditor/trunk

Files:

• CHANGES.html (modified) (1 diff)
• _source/plugins/dialog/plugin.js (modified) (4 diffs)

CKEditor/trunk/CHANGES.html

@@ -79 +79 @@
                 <li><a href="http://dev.ckeditor.com/ticket/6791">#6791</a> : [IE7] Editor didn't show up when the replaced textarea's name was matching to the name of a meta tag in the page.</li>
                 <li><a href="http://dev.ckeditor.com/ticket/5684">#5684</a> : [FF] When "forcePasteAsPlainText" is used, cursor disappears after paste.</li>
+                <li><a href="http://dev.ckeditor.com/ticket/6390">#6390</a> : Prevents toolbar dialog buttons from being clicked twice.</li>
         </ul>
         <h3>

CKEditor/trunk/_source/plugins/dialog/plugin.js

@@ -711 +711 @@
                 show : function()
                 {
-                        var editor = this._.editor;
-                        if ( editor.mode == 'wysiwyg' && CKEDITOR.env.ie )
-                        {
-                                var selection = editor.getSelection();
-                                selection && selection.lock();
-                        }
-
                         // Insert the dialog's element to the root document.
                         var element = this._.element;
@@ -1853 +1846 @@
                 {
                         var html = [
-                                        '<div style="position: ', ( CKEDITOR.env.ie6Compat ? 'absolute' : 'fixed' ),
+                                        '<div tabIndex="-1" style="position: ', ( CKEDITOR.env.ie6Compat ? 'absolute' : 'fixed' ),
                                         '; z-index: ', baseFloatZIndex,
                                         '; top: 0px; left: 0px; ',
@@ -1934 +1927 @@
                 win.on( 'resize', resizeFunc );
                 resizeFunc();
+                coverElement.focus();
                 if ( CKEDITOR.env.ie6Compat )
                 {
@@ -2897 +2891 @@
 
         })();
+
+        // Extend the CKEDITOR.editor class with dialog specific functions.
+        CKEDITOR.tools.extend( CKEDITOR.editor.prototype,
+                /** @lends CKEDITOR.editor.prototype */
+                {
+                        /**
+                         * Loads and opens a registered dialog.
+                         * @param {String} dialogName The registered name of the dialog.
+                         * @param {Function} callback The function to be invoked after dialog instance created.
+                         * @see CKEDITOR.dialog.add
+                         * @example
+                         * CKEDITOR.instances.editor1.openDialog( 'smiley' );
+                         * @returns {CKEDITOR.dialog} The dialog object corresponding to the dialog displayed. null if the dialog name is not registered.
+                         */
+                        openDialog : function( dialogName, callback )
+                        {
+                                if ( this.mode == 'wysiwyg' && CKEDITOR.env.ie )
+                                {
+                                        var selection = this.getSelection();
+                                        selection && selection.lock();
+                                }
+
+                                var dialogDefinitions = CKEDITOR.dialog._.dialogDefinitions[ dialogName ],
+                                                dialogSkin = this.skin.dialog;
+
+                                if ( CKEDITOR.dialog._.currentTop === null )
+                                        showCover( this );
+
+                                // If the dialogDefinition is already loaded, open it immediately.
+                                if ( typeof dialogDefinitions == 'function' && dialogSkin._isLoaded )
+                                {
+                                        var storedDialogs = this._.storedDialogs ||
+                                                ( this._.storedDialogs = {} );
+
+                                        var dialog = storedDialogs[ dialogName ] ||
+                                                ( storedDialogs[ dialogName ] = new CKEDITOR.dialog( this, dialogName ) );
+
+                                        callback && callback.call( dialog, dialog );
+                                        dialog.show();
+
+                                        return dialog;
+                                }
+                                else if ( dialogDefinitions == 'failed' )
+                                        throw new Error( '[CKEDITOR.dialog.openDialog] Dialog "' + dialogName + '" failed when loading definition.' );
+
+                                var me = this;
+
+                                function onDialogFileLoaded( success )
+                                {
+                                        var dialogDefinition = CKEDITOR.dialog._.dialogDefinitions[ dialogName ],
+                                                        skin = me.skin.dialog;
+
+                                        // Check if both skin part and definition is loaded.
+                                        if ( !skin._isLoaded || loadDefinition && typeof success == 'undefined' )
+                                                return;
+
+                                        // In case of plugin error, mark it as loading failed.
+                                        if ( typeof dialogDefinition != 'function' )
+                                                CKEDITOR.dialog._.dialogDefinitions[ dialogName ] = 'failed';
+
+                                        me.openDialog( dialogName, callback );
+                                }
+
+                                if ( typeof dialogDefinitions == 'string' )
+                                {
+                                        var loadDefinition = 1;
+                                        CKEDITOR.scriptLoader.load( CKEDITOR.getUrl( dialogDefinitions ), onDialogFileLoaded, null, 0, 1 );
+                                }
+
+                                CKEDITOR.skins.load( this, 'dialog', onDialogFileLoaded );
+
+                                return null;
+                        }
+                });
 })();
-
-// Extend the CKEDITOR.editor class with dialog specific functions.
-CKEDITOR.tools.extend( CKEDITOR.editor.prototype,
-        /** @lends CKEDITOR.editor.prototype */
-        {
-                /**
-                 * Loads and opens a registered dialog.
-                 * @param {String} dialogName The registered name of the dialog.
-                 * @param {Function} callback The function to be invoked after dialog instance created.
-                 * @see CKEDITOR.dialog.add
-                 * @example
-                 * CKEDITOR.instances.editor1.openDialog( 'smiley' );
-                 * @returns {CKEDITOR.dialog} The dialog object corresponding to the dialog displayed. null if the dialog name is not registered.
-                 */
-                openDialog : function( dialogName, callback )
-                {
-                        var dialogDefinitions = CKEDITOR.dialog._.dialogDefinitions[ dialogName ],
-                                        dialogSkin = this.skin.dialog;
-
-                        // If the dialogDefinition is already loaded, open it immediately.
-                        if ( typeof dialogDefinitions == 'function' && dialogSkin._isLoaded )
-                        {
-                                var storedDialogs = this._.storedDialogs ||
-                                        ( this._.storedDialogs = {} );
-
-                                var dialog = storedDialogs[ dialogName ] ||
-                                        ( storedDialogs[ dialogName ] = new CKEDITOR.dialog( this, dialogName ) );
-
-                                callback && callback.call( dialog, dialog );
-                                dialog.show();
-
-                                return dialog;
-                        }
-                        else if ( dialogDefinitions == 'failed' )
-                                throw new Error( '[CKEDITOR.dialog.openDialog] Dialog "' + dialogName + '" failed when loading definition.' );
-
-                        // Not loaded? Load the .js file first.
-                        var body = CKEDITOR.document.getBody(),
-                                cursor = body.$.style.cursor,
-                                me = this;
-
-                        body.setStyle( 'cursor', 'wait' );
-
-                        function onDialogFileLoaded( success )
-                        {
-                                var dialogDefinition = CKEDITOR.dialog._.dialogDefinitions[ dialogName ],
-                                                skin = me.skin.dialog;
-
-                                // Check if both skin part and definition is loaded.
-                                if ( !skin._isLoaded || loadDefinition && typeof success == 'undefined' )
-                                        return;
-
-                                // In case of plugin error, mark it as loading failed.
-                                if ( typeof dialogDefinition != 'function' )
-                                        CKEDITOR.dialog._.dialogDefinitions[ dialogName ] = 'failed';
-
-                                me.openDialog( dialogName, callback );
-                                body.setStyle( 'cursor', cursor );
-                        }
-
-                        if ( typeof dialogDefinitions == 'string' )
-                        {
-                                var loadDefinition = 1;
-                                CKEDITOR.scriptLoader.load( CKEDITOR.getUrl( dialogDefinitions ), onDialogFileLoaded );
-                        }
-
-                        CKEDITOR.skins.load( this, 'dialog', onDialogFileLoaded );
-
-                        return null;
-                }
-        });
 
 CKEDITOR.plugins.add( 'dialog',