No need to confirm that "Cancel" button has been pressed

[Henrik Helmø Larsen]

I think it is very annoying that you have to (in some cases) confirm that you want to cancel opening a dialog. It would be nice if it could be possible to have a: CKEDITOR.config.ignoreConfirmCancel = true; which never would show the confirm dialog: "Some of the options have been changed. Are you sure to close the dialog?"

The dialog always appears if on the Link-dialog a change has been made in a combobox (dropdown) - for example the "Link Type"-combobox.

[Henrik Helmø Larsen]

"Confirm-cancel" dialog being displayed because Link Type has changed

[Henrik Helmø Larsen]

Sorry - forgot to write I am using CKEditor 4.0.1 (using Chrome on a Win 7 Ultimate 64bit machine)

[Jakub Ś]

Currently there is no option to disable this. It would be nice however to give users choice.

@Helmø code you are looking for is located in ckeditor/plugins/dialog/plugin.js

this.on( 'cancel', function( evt ) {
...

[Henrik Helmø Larsen]

Exactly - I have added the following code:

this.on( 'cancel', function( evt ) {
  if (!editor.config.ignoreConfirmCancel) {
    iterContents( function( item ) {
      if ( item.isChanged() ) {
        if ( !confirm( editor.lang.common.confirmCancel ) )
          evt.data.hide = false;
            return true;
      }
    });
  }
}, this, null, 0 );

if (!editor.config.ignoreConfirmCancel) being the added code.

And then I have defined config.ignoreConfirmCancel = true; in config.js

[Claire Martinez]

Any idea when this will be patched in? 4.2.1 perhaps?

[Marek Lewandowski]

Fixed with ​git:a93d09be787 on dev and 108d0c5f on tests. Branch t/10028.

[Henrik Helmø Larsen]

Thank you

[Piotr Jasiun]

For me this change is now ok, but it should wait until next week until Fred will be back, to get green light.

[Piotrek Koszuliński]

This is a new feature so ideally it would land on 4.3, not 4.2.2.

Plus some things with the doc string:

• there is no name of an option specified,
• in official documentation you should not use contractions like "it's", "shouldn't".

[Frederico Caldeira Knabben]

Yes, that's a new feature, so 4.3.

[Frederico Caldeira Knabben]

The configuration name is not good. If you look at it out of the box, "ignoreConfirmCancel" is quite confusing and has no association with dialogs. I would propose "dialog_noConfirmCancel", to also align to the new naming convention for plugins.

[Marek Lewandowski]

Branch t/10028 (dev and tests) updated, requesting for next review.

[Piotrek Koszuliński]

After some additional fixes in tests and doc str, R+.

[Piotrek Koszuliński]

Merged to major on ​git:1828df8 on dev and dd65c85 on tests.