Opened 13 years ago
Closed 13 years ago
#10268 closed Bug (fixed)
'Show Blocks' do not recover after 'Source' view
| Reported by: | Roman | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.1.1 |
| Component: | General | Version: | 4.1 |
| Keywords: | Cc: |
Description
Hi Team,
How reproduce:
- Go to http://ckeditor.com/demo#full (version 4.1)
- Click on 'Show Bloks', blocks appear
- Click on 'Source'
- Click on 'Show Bloks', blocks do not appear, but button stay pushed down.
Thanks!
Change History (3)
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
| Keywords: | Show Blocks Source removed |
|---|---|
| Status: | new → confirmed |
| Version: | → 4.1 |
Problem can be reproduced in all browsers from CKEditor 4.1.
comment:3 Changed 13 years ago by
| Milestone: | → CKEditor 4.1.1 |
|---|---|
| Resolution: | → fixed |
| Status: | confirmed → closed |
Fixed by #10249.

Update.
Looks like problem is here http://dev.ckeditor.com/browser/CKEditor/trunk/_source/plugins/showblocks/plugin.js#L139
command.state equal to by somehow CKEDITOR.TRISTATE_DISABLED
135 // Refresh the command on setData. 136 editor.on( 'mode', function() 137 { 138 if ( command.state != CKEDITOR.TRISTATE_DISABLED ) 139 command.refresh( editor ); 140 });Test: I added this into custom plugin
editor.on( 'mode', function() { var command = editor.commands.showblocks; console.log("command.state = " + command.state, "CKEDITOR.TRISTATE_DISABLED = " + CKEDITOR.TRISTATE_DISABLED); if ( command.state != CKEDITOR.TRISTATE_DISABLED ) { command.refresh( editor ); } });Then I did:
I created wired fix for myself for now, maybe it could be helpful somebody -)
editor.on('mode', function( evt ) { /** * Temporary fix * Issue: http://dev.ckeditor.com/ticket/10268 */ editor.commands.showblocks.refresh( editor ); });