Opened 12 years ago
Closed 11 years ago
#10368 closed Bug (fixed)
Move language reading direction definition ("dir") from main language file to core
Reported by: | Wiktor Walc | Owned by: | Piotr Jasiun |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.2.1 |
Component: | UI : Language | Version: | |
Keywords: | Cc: |
Description (last modified by )
It happens quite often that translators confuse the "dir" entry in main language file and try to translate it into something (e.g. between 4.1 and 4.1.1 releases two language files would get broken because of that).
Since we already store information about available language files in core/lang.js (CKEDITOR.lang), I'd like to propose moving this meta information about a language also to core.
Language files should contain only things that are supposed to be translated. Any other information should be moved outside of it.
Change History (10)
comment:1 Changed 12 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 12 years ago by
Status: | new → confirmed |
---|
comment:3 Changed 12 years ago by
comment:4 Changed 12 years ago by
Milestone: | → CKEditor 4.2.1 |
---|
comment:5 Changed 12 years ago by
Owner: | set to Piotr Jasiun |
---|---|
Status: | confirmed → assigned |
comment:7 Changed 11 years ago by
Status: | review → review_failed |
---|
- There's an unrelated commit in the branch (1765d6abb32c).
- We could save some bytes by changing:
languages: { 'af':1,'ar':1,'bg':1,'foo-bar':1 ... }
tolanguages: { af:1,ar:1,bg:1,'foo-bar':1 ... }
CKEDITOR.lang.languages[ languageCode ];
inscriptLoader.load( ... )
isthis.languages[ languageCode ];
(context passed to the loader, isn't it?).- We need
CKEDITOR.lang.rtl
for package builder (Wiktor will explain ;)
comment:8 Changed 11 years ago by
Status: | review_failed → review |
---|
I've separated list of supported languages and list of right-to-left languages. To save some bytes default is LTR and I keep only list of RTLs. I also fixed rest of issues.
- branch: t/10368
comment:9 Changed 11 years ago by
Status: | review → review_passed |
---|
Pushed a very minor fix to the branch.
I can confirm that this used to happen quite often outside Transifex and still happens in Transifex even though we do have a comment to that string stating what the allowed values are.