Save toolbar button saves only first instance

[gifad]

If multiple ckeditor instances are present in the form, only the first instance is saved (others are posted in their original state);

New to 4.2 (4.1.3 ok)(also present in latest github)

Firefox, webkit, no javascript error

reproduced in duplicating "editor1" textarea => "editor2" in ckeditor/samples/replacebyclass.html

also obvious (and critical) in drupal, which uses a first instance as "summary'

[Jakub Ś]

I was able to reproduce this in all browsers from CKE 4.2 just like @gifad has described.

[Jakub Ś]

#10696 was marked as duplicate.

[Piotr Jasiun]

Fixed.

​git:469d5eb

[Piotr Jasiun]

No tests. They would be too time consuming.

[Piotr Jasiun]

One more commit with comment how (why!) it was actually working.

​git:6ab7614

[Piotrek Koszuliński]

For future reference - why this was an incorrect duck typing:

    if ( !form.$.submit.nodeName && !form.$.submit.length )

This works correctly for the first editor - it checks whether submit property of a form is an element or HTML collection (of inputs with name=submit). However, it fails for the second one because overridden submit property now has a length property, because function has it too (it means the number of arguments listed in fn def). So the second editor cannot override form.$submit.

However, the if ( !form.$.submit.nodeName ) as proposed by PJ is not enough. Only IE8 allows to override form.submit being an element or HTML collection, and... it throws an error then. So we need more precise duck typing.

[Piotrek Koszuliński]

PS. I don't like the fact that save plugin works by an accident, but to fix this we would have to double the effort, so this topic should not be included in this ticket. Let's report a ticket for it after closing this one (because something may change in the meantime).

[Piotr Jasiun]

Now I'm checking if form.$.submit is function using duck type. I cannot use typeof because for IE8 type of function is object.

And I also don't like magic in ​this part of code. I think we should use save event (instead of submit) to cancel submition when user press save button. I created ticket for it: #10748.

[Piotr Jasiun]

Manual Test

[Piotr Jasiun]

​git:b154b45