Opened 11 years ago
Closed 11 years ago
#10823 closed Bug (fixed)
Link plugin fails when applied to a non-editable content
| Reported by: | Piotrek Koszuliński | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Must have (possibly next milestone) | Milestone: | CKEditor 4.3 |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description (last modified by )
In link/dialogs/link.js:
var range = selection.getRanges( 1 )[ 0 ];
// Use link URL as text with a collapsed cursor.
if ( range.collapsed ) {
These lines cause problem, because ranges is an empty array if only widget (non-editable content) is selected.
Change History (7)
comment:1 Changed 11 years ago by
| Description: | modified (diff) |
|---|---|
| Status: | new → confirmed |
| Summary: | Link plugin fails when applied to non-editable content → Link plugin fails when applied to a non-editable content |
comment:2 Changed 11 years ago by
| Priority: | Normal → High |
|---|
comment:3 Changed 11 years ago by
comment:4 Changed 11 years ago by
| Owner: | set to Piotrek Koszuliński |
|---|---|
| Status: | confirmed → assigned |
comment:5 Changed 11 years ago by
| Status: | assigned → review |
|---|
comment:6 Changed 11 years ago by
| Status: | review → review_passed |
|---|
comment:7 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed on major with git:fc83fe7 on dev and a8bfc0c on tests.
Note: See
TracTickets for help on using
tickets.
I think that #10822 should go before this ticket. After we'll fix applying styles on non-editable elements, we will be able to just get a full range (currently only the editable part is extracted, which in case of widget selection is empty) from selection and apply link's style on it.