Opened 12 years ago
Closed 12 years ago
#10833 closed Bug (fixed)
Image2: “Lock ratio” should be on by default.
| Reported by: | Olek Nowodziński | Owned by: | Olek Nowodziński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.3 |
| Component: | General | Version: | 4.3 Beta |
| Keywords: | Cc: |
Description
Referring to: http://dev.ckeditor.com/ticket/10659#comment:8
Change History (14)
comment:1 Changed 12 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 12 years ago by
| Owner: | set to Olek Nowodziński |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 12 years ago by
| Status: | assigned → review |
|---|
comment:4 Changed 12 years ago by
| Status: | review → review_failed |
|---|
- Doubleclick on image, disable the "lock ratio" option.
- Change size of an image to unproportional and close dialog.
- Doubleclick on image again to open dialog.
- Expected: since unproportional size is set the "lock ration" option should be disabled.
- Actual: "lock ratio" is enabled.
This works on image plugin.
comment:5 Changed 12 years ago by
| Status: | review_failed → review |
|---|
comment:6 Changed 12 years ago by
| Status: | review → review_passed |
|---|
comment:7 Changed 12 years ago by
| Status: | review_passed → review_failed |
|---|
Oups. It turned out that this patch introduced #10958.
comment:8 follow-up: 9 Changed 12 years ago by
| Status: | review_failed → review |
|---|
Updated dev branch:
- Fixed #10958.
- Introduced widget.data.lock.
- Introduced shared helper functions
checkHasNaturalRatioandgetNatural. - Bypassed lack of support for
$.natural(Width|Height)in IE8 withCKEDITOR.plguins.image2.getNatural
comment:9 follow-up: 10 Changed 12 years ago by
| Status: | review → review_failed |
|---|
Replying to a.nowodzinski:
Updated dev branch:
- Fixed #10958.
- Introduced widget.data.lock.
- Introduced shared helper functions
checkHasNaturalRatioandgetNatural.- Bypassed lack of support for
$.natural(Width|Height)in IE8 withCKEDITOR.plguins.image2.getNatural
:/ I don't see anything of this in t/10833 ???
comment:10 Changed 12 years ago by
| Status: | review_failed → review |
|---|
Replying to fredck:
:/ I don't see anything of this in t/10833 ???
My fault. I've just pushed the code to that branch.
comment:11 follow-up: 12 Changed 12 years ago by
| Status: | review → review_failed |
|---|
I see that the lock ratio behavior is much better now. It's a good improvement.
Buuuut… there is still an important issue, especially when you read the ticket title which says "“Lock ratio” should be on by default"…. when you open the image2 dialog to insert a new image, the lock thing is "off", instead of being "on"… by default.
Let's have this last missing thing dealt as well
comment:12 Changed 12 years ago by
| Status: | review_failed → review |
|---|
Replying to fredck:
I see that the lock ratio behavior is much better now. It's a good improvement.
Buuuut… there is still an important issue, especially when you read the ticket title which says "“Lock ratio” should be on by default"…. when you open the image2 dialog to insert a new image, the lock thing is "off", instead of being "on"… by default.
Let's have this last missing thing dealt as well
Yeah. I fixed everything except what this ticket is about :P
Pushed a commit to dev branch and rebased on latest major.
comment:13 Changed 12 years ago by
| Status: | review → review_passed |
|---|
comment:14 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Branch merged into major: git:d792be6
Created branch t/10833 with 1LOC fix.