Opened 12 years ago
Closed 12 years ago
#11081 closed Task (fixed)
JSLint 4.3
| Reported by: | Olek Nowodziński | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.3 |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description
For a better world.
Change History (8)
comment:1 Changed 12 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 12 years ago by
| Owner: | set to Piotr Jasiun |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 12 years ago by
| Status: | assigned → review |
|---|
comment:4 Changed 12 years ago by
| Status: | review → review_failed |
|---|
What's the point of fixing JSLint issues when still some tickets are pending? This got to be done once everything is merged into major, right before testing phase.
comment:5 Changed 12 years ago by
| Status: | review_failed → review |
|---|
Maybe I was not enough clear. I want someone check changes in style.removeFromInsideElement. After that I will put this ticket again in 'assigned'.
comment:6 Changed 12 years ago by
| Status: | review → assigned |
|---|
comment:7 Changed 12 years ago by
| Owner: | Piotr Jasiun deleted |
|---|---|
| Status: | assigned → confirmed |
comment:8 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | confirmed → closed |
Fixed on major with git:b118c02.
Note: See
TracTickets for help on using
tickets.
There were a mess in
style.removeFromInsideElementfunction. I fixed it based on master version, but please check in again during review. That is a shame that there are no tests checking if it works properly.A also added some missing semicolons and added
Imageand$to global definitions.