Image2: iframes/flashes are converted into image2 widgets when pasted

[Marek Lewandowski]

Image2: iframes/flashes are converted into image2 widgets when pasted

since: 4.3 until major

It seems that currently enabling image2 plugin will convert iframes/flashes into its widget.

1. open image2 sample (/samples/plugins/image2/image2.html)
2. switch to source mode
3. input following code

   <p>n t<iframe frameborder="0" scrolling="no" src="www.wikipedia.org"></iframe>e d</p>
   

4. switch back to wysiwyg mode
5. ctrl+a (select all)
6. ctrl+c (copy)
7. move cursor at the end of content
8. ctrl+p (paste)

Expected result:
Pasted content should contain iframe. Produced source code:

<p>n t<iframe frameborder="0" scrolling="no" src="www.wikipedia.org"></iframe>e dn t<iframe frameborder="0" scrolling="no" src="www.wikipedia.org"></iframe>e d</p>

Current result:
Pasted content contain image2 instead of an iframe. Code with image:

<p>n t<iframe frameborder="0" scrolling="no" src="www.wikipedia.org"></iframe>e dn t<img alt="IFrame" src="http://presets.ckeditor.dev/4.3/full-all/ckeditor/plugins/fakeobjects/images/spacer.gif?t=DA89" title="IFrame" />e d</p>

additional info:

1. issue does not occur for other widget-based plugins like mathjax, placeholder
2. issue seems to be cross browser

[Piotrek Koszuliński]

Pushed ​t/11110 on dev and tests.

[Piotrek Koszuliński]

Pasting still does not work ;|

[Piotrek Koszuliński]

It turned out that fakeobjects does not allow HTML which it requires, so when there is no image plugin (which allows all classes), the cke_iframe class was stripped.

I pushed the easiest fix for that I could think of - we just allow all important properties on images with data-cke-realelement attributes. It's not ideal, because ideally we should be more precise (and filter the real element's HTML), but fakeobjects is kind of old-school plugin, so we can accept this solution.

The dev changes should not have impact on editor's behaviour, however, may have on tests.

[Piotrek Koszuliński]

Fixed on major with ​git:bfd103821 on dev and 358db53 + 9fdbc07 on tests.