Ticket #1115 (closed Bug: fixed)

Opened 7 years ago

Last modified 7 years ago

Revert [736], by default the upload directories should be set as previous versions.

Reported by: alfonsoml Owned by: wwalc
Priority: Normal Milestone: FCKeditor 2.5 Beta
Component: Server : PHP Version: SVN (FCKeditor) - Retired
Keywords: Cc: fredck

Description

Hi

The configuration of the QuickUpload for the PHP connector was set that way according to http://dev.fckeditor.net/ticket/454#comment:18 to keep backwards compatibility.

The Python connector on the other side didn't had a quickupload previously, so when it was added in #575 it was possible to use a more logical configuration by default.

If now it is changed it should be strongly marked in the release notes or lots of people will say that it's broken (even putting the info isn't enough as they just don't read them)

Change History

comment:1 follow-up: ↓ 3 Changed 7 years ago by wwalc

  • Status changed from new to closed
  • Resolution set to fixed

Hi Alfonso,

Thanx for pointing this out.

I've decided to make this like it's done in Python connector because I thought it would be much more user friendly (currently, after uploading file, it's not visible in file browser). However you're right that many people may have problems with that after upgrading... so I think we could mention about it in config.php file that, to avoid confusion, one might change default:

$Config['QuickUploadPath']['File']		= $Config['UserFilesPath'] ;
$Config['QuickUploadAbsolutePath']['File']= $Config['UserFilesAbsolutePath'] ;

into

$Config['QuickUploadPath']['File']		= $Config['FileTypesPath']['File'] ;
$Config['QuickUploadAbsolutePath']['File']= $Config['FileTypesAbsolutePath']['File'] ;

what do you think?

comment:2 Changed 7 years ago by wwalc

[736] has been reverted with [740].

comment:3 in reply to: ↑ 1 Changed 7 years ago by alfonsoml

Replying to wwalc:

Hi Alfonso,

Thanx for pointing this out.

I've decided to make this like it's done in Python connector because I thought it would be much more user friendly (currently, after uploading file, it's not visible in file browser). However you're right that many people may have problems with that after upgrading... so I think we could mention about it in config.php file that, to avoid confusion, one might change default:

$Config['QuickUploadPath']['File']		= $Config['UserFilesPath'] ;
$Config['QuickUploadAbsolutePath']['File']= $Config['UserFilesAbsolutePath'] ;

into

$Config['QuickUploadPath']['File']		= $Config['FileTypesPath']['File'] ;
$Config['QuickUploadAbsolutePath']['File']= $Config['FileTypesAbsolutePath']['File'] ;

what do you think?

Yes, it would be a good idea to document that.

Maybe not just in the config file, but in the Wiki, with a small page just explaining the different options and how to get different behaviors changing those settings (Expanding what currently exists in http://wiki.fckeditor.net/Developer%27s_Guide/Configuration/Built_in_File_Browser)

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy