Opened 12 years ago
Closed 12 years ago
#11290 closed Bug (fixed)
[PR#66] Redundant code in sourcedialog plugin
| Reported by: | Marek Lewandowski | Owned by: | Marek Lewandowski |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.3.2 |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description (last modified by )
Until master
As github user stevewithington points out in pull request #66:
We have code duplication in plugins/sourcedialog/dialogs/sourcedialog.js which can be fixed very easily.
Change History (6)
comment:1 Changed 12 years ago by
| Description: | modified (diff) |
|---|---|
| Status: | new → confirmed |
| Summary: | redunant code in sourcedialog plugin - pull request #66 → Redunant code in sourcedialog plugin - pull request #66 |
comment:2 Changed 12 years ago by
| Owner: | set to Marek Lewandowski |
|---|---|
| Status: | confirmed → review |
comment:3 Changed 12 years ago by
| Summary: | Redunant code in sourcedialog plugin - pull request #66 → [PR#66] Redunant code in sourcedialog plugin |
|---|
Changed ticket title to meet our standards.
comment:4 Changed 12 years ago by
| Status: | review → review_passed |
|---|
comment:5 Changed 12 years ago by
| Summary: | [PR#66] Redunant code in sourcedialog plugin → [PR#66] Redundant code in sourcedialog plugin |
|---|
fixed typo
comment:6 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
fixed with git:df273395c
Note: See
TracTickets for help on using
tickets.
Pushed to t/11290