Styles Combo: Select combo list is disabled when only object styles are defined

[mmikitka]

Descriptive summary

If one only supplies object styles to config.styleSet, the Styles select combo list remains disabled, even when an object supporting at least one of the defined styles is selected.

Steps to reproduce

1. Use a config.styleSet definition like the following, which only contains object styles:

CKEDITOR.config.stylesSet = [

{ name: 'Square Bulleted List', element: 'ul', styles: { 'list-style-type': 'square' } }

];

2. Reload CKEditor

3. Create a bulleted list

4. The Select list remains disabled

Browser and OS Tested on Chrome and Firefox on Ubuntu 12.04.03

Screenshot Not included

Sample data See config.styleSet definition above

Test case file None

Build configuration None

[mmikitka]

I just pushed the following proposed fix: ​https://github.com/mmikitka/ckeditor-dev/commit/434af7ee1959383c22973f55c90a487388da1b51

[Jakub Ś]

I was able to reproduce this problem from CKEditor 4.3 in all browsers except for IE. Yes, for change IE is the only working browser, while others are failing.

NOTE: this doesn't happen in 4.3 beta.

[Piotr Jasiun]

First bad commit is ​7511404.

[Piotr Jasiun]

Working on #10848 we were sure that the state of style combo can change only when active filter changes or mode changes so I removed updateState method from the list of selectionChange listeners. It appears to be a mistake. I reverted that change and added tests.

Changes in ​t/11568 and corresponding test branch.

[Piotrek Koszuliński]

Kudos!

I force-pushed both rebased branches + some small fixes.

[Piotr Jasiun]

• ​git:4be02f3
• tests:28828a7