Switching between modes in framed editor removes content styles for inline editor

[Piotrek Koszuliński]

1. Download 11641.html​
2. Switch between modes in first editor.
3. See that content in inline editor lost styles.

[Olek Nowodziński]

cc: love this one!

[Piotr Jasiun]

The problem was in editable.detach method. When editor was in textarea mode this method removes styles from the page document (this.getDocument() for textarea was page document).

Changes in ​t/11641 and corresponding test branch.

[Piotrek Koszuliński]

I wonder if there's any more straightforward way of checking if stylesheet should be removed. What if someone used other source mode than sourcearea? For example source code editor?

What if we set editable.hasStylesheet property when it adds stylesheet and then check it in detach?

PS. There are 3 minor code style issues in tests.

[Piotr Jasiun]

I'm also not sure if this.is( 'textarea' ) is the best way to check this, but this way is already used in other places in this file (​here and ​here) and I believe that it is most important to use the same check everywhere. If we want to let user use custom source code editor we should rethink all of the if( this.is( 'textarea' ) ) conditions.

[Piotrek Koszuliński]

Ok, you're right. We already use this check, so in this case we can do that too. However, we should take the opportunity to fix this as soon as we'll make some refactoring of editable class. The entire addCss logic is tangled. There are better ways to ensure that stylesheet will be preserved as long as there's at least one editor using it.

[Piotr Jasiun]

• ​git:eec6b82
• tests:5e3603f