Ticket #1171 (closed Bug: fixed)

Opened 7 years ago

Last modified 7 years ago

An insertion of any kind of INPUT element is not undoable.

Reported by: aleksey Owned by:
Priority: Normal Milestone: FCKeditor 2.5 Beta
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Confirmed Cc:

Description

Steps to reproduce (for checkboxes, radiobuttons, etc).

  1. Load sample01.html
  2. Set the cursor at the end of text.
  3. Press Checkbox button on the toolbar. A dialog window will appear.
  4. Fill the fields in and press Ok button.

A checkbox has been inserted but Undo button is disabled.

This can be fixed pretty easy by adding the following line in Ok function of the appropriate dialog window (see dialog/fck_table.html for example).

oEditor.FCKUndo.SaveUndoStep() ;

But I wonder if this behaviour is intentional.

Change History

comment:1 Changed 7 years ago by fredck

  • Keywords Confirmed added
  • Version set to SVN
  • Milestone set to FCKeditor 2.5

Those kinds of actions must certainly be undoable.

comment:2 Changed 7 years ago by aleksey

  • Status changed from new to closed
  • Resolution set to fixed

Fixed with [775].

comment:3 Changed 7 years ago by fredck

  • Status changed from closed to reopened
  • Resolution fixed deleted

Aleksey, with your fix, you are calling SaveUndoStep only when inserting new objects in the editor, but not when simply making changes to already existing things. I believe both actions must be undoable, even if in some cases the undo will not bring a visual effect (when changing a field name, for example). I think that call should be in the first line inside the Ok().

Is there any motivation for your choice?

comment:4 Changed 7 years ago by aleksey

  • Status changed from reopened to closed
  • Resolution set to fixed

You are right. The both actions must be undoable.

Fixed with [778].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy