Imperfections in moono ui styles

[Danil]

• "Browse" button has wrong top margin.
• Combobox has cursor:pointer over an arrow and borders.
• Specialchars table has cells of different widths.
• Dialog buttons and selects has 24px height, while textfields 25px
• "Close" button background is not centered. The button has no "hover" effect.

[Danil]

I made a pull request, but don't know how to link it properly to this ticket: ​https://github.com/ckeditor/ckeditor-dev/pull/91

[Jakub Ś]

This is something we definitely can improve.

[Olek Nowodziński]

I reviewed ​​https://github.com/ckeditor/ckeditor-dev/pull/91. A few remarks here:

• ​git:7b99019 Get rid of pointer cursor over some richcombo areas.

I'm OK with cursor:default for groups inside of the combo (.cke_panel_grouptitle). Nice catch. Also I find cursor:default right for the drop-down arrow in the toolbar since it was the only UI element in the toolbar that changed cursor on hover.

• ​git:8722ea0 Make specialchars table cells equal in width.

This change has no impact or it's negligible. Rejected.

• ​git:cedebb5 Correct colordialog color textfield width.

IE fix (i.e. IE8). It's correct.

• ​git:1c9d199 Adjust find dialog field sizes (mostly for non-english languages)

I'm not able to reproduce any issue here. Also that commit brings no visual change for me. Rejected.

• ​git:442ab14 A bit correct "browse" button top offset.

Nice catch. It's correct.

• ​git:a8ca7cb Correct button and select height

This one is also fine.

• ​git:2f86e66 Center x in close button, add a slight hover effect to it

That's true. "x" was not centered right. As for the hover effect, it's an eyecandy and I like it.

Generally speaking I feel great about this PR. Kudos to danya_postfactum. I pushed ​branch:t/11757 which does not contain rejected commits and, if double-checked, I'm for merging it into master.

[Piotrek Koszuliński]

Thanks Olek and of course thanks danya_postfactum.

@danya_postfactum: do you agree with Olek's review (mainly - with the rejected comments)? We'll wait for your feedback before merging this branch into master, so we can bring back your commits which were rejected.

[Piotrek Koszuliński]

Ok, time to merge this to master.

[Piotrek Koszuliński]

Fixed on master with ​git:f5acc04. Huge thanks for the pull request!