#11859 closed Bug (fixed)
Code snippet sample cannot rely on sourcedialog
| Reported by: | Piotrek Koszuliński | Owned by: | Artur Delura |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.4.1 |
| Component: | Documentation & Samples | Version: | 4.4.0 |
| Keywords: | Cc: |
Description
Sample from package that contains codesnippet plugin but no sourcedialog throws an error because inline editor uses extraPlugins setting.
Change History (8)
comment:1 Changed 10 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 10 years ago by
| Owner: | set to Artur Delura |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 10 years ago by
| Status: | assigned → review |
|---|
comment:4 Changed 10 years ago by
| Status: | review → review_failed |
|---|
You do not need to remove 'Source' from toolbar, only 'Sourcedialog'.
comment:5 Changed 10 years ago by
| Status: | review_failed → review |
|---|
Just restored missed button in https://github.com/cksource/ckeditor-dev/tree/t/11859
comment:6 Changed 10 years ago by
| Status: | review → review_passed |
|---|
Good job. Now, remember about two things before merging to master:
- Squash those two commits together. The 2nd one has no value, because it reverts part of 1st. So better to have one.
- Rebase on master.
Ask PJ or Marek for guidance with masterising.
Note: See
TracTickets for help on using
tickets.
Changes in https://github.com/cksource/ckeditor-dev/commits/t/11859.