Opened 3 years ago

Closed 3 years ago

#11957 closed Bug (fixed)

[Image2] Alignment labels in the dialog are not translated

Reported by: a.nowodzinski Owned by: a.nowodzinski
Priority: Normal Milestone: CKEditor 4.4.2
Component: UI : Dialogs Version: 4.3
Keywords: Cc:

Description

At the moment labels are hardcoded and just look silly if changed editor language to Polish or any other.

Change History (8)

comment:1 Changed 3 years ago by a.nowodzinski

  • Summary changed from [Image2] Image2 alignment labels are not translated to [Image2] Alignment labels in the dialog are not translated

comment:2 Changed 3 years ago by a.nowodzinski

  • Status changed from new to confirmed

comment:3 Changed 3 years ago by a.nowodzinski

  • Owner set to a.nowodzinski
  • Status changed from confirmed to assigned

comment:4 Changed 3 years ago by a.nowodzinski

  • Status changed from assigned to review

Fix pushed to branch:t/11957.

comment:5 follow-up: Changed 3 years ago by a.delura

It works now, but not for end user. Until we add translations for a diffrent languages there will be no text next to align none checkbox in image2 dialog. alignNone key is added only for english language.

comment:6 in reply to: ↑ 5 Changed 3 years ago by a.nowodzinski

Replying to a.delura:

It works now, but not for end user. Until we add translations for a diffrent languages there will be no text next to align none checkbox in image2 dialog. alignNone key is added only for english language.

Your concern is only valid for dev code. Once built, missing translations are automatically filled with english strings, just like https://github.com/ckeditor/ckeditor-dev/blob/master/lang/tt.js#L65-L67 and this is a part of our translation workflow. If what you said was true, we would not be able to extend any existing langfile until all remaining languages are 100% coherent, which is absurd ;)

comment:7 Changed 3 years ago by a.delura

I see, it would be weird :)

comment:8 Changed 3 years ago by Reinmar

  • Resolution set to fixed
  • Status changed from review to closed

Fixed on master with git:026c14e.

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy