Opened 11 years ago

Closed 11 years ago

#12130 closed Bug (fixed)

Bender.tools.range.getWithHtml prunes element ids

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.4.3
Component: General Version:
Keywords: Cc:

Description

Because of

​https://github.com/benderjs/benderjs-ckeditor/blob/cdd10213ec748101f0e3d9eead8da01fb8f04245/static/tools.js#L1108

and

​https://github.com/benderjs/benderjs-ckeditor/blob/cdd10213ec748101f0e3d9eead8da01fb8f04245/static/tools.js#L1069 (IE),

element ids are pruned. This is the default behavior of CKEDITOR.dom.node.clone(), which is undesired in bender.tools.range.getWithHtml().

Change History (6)

comment:1 Changed 11 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: new → assigned

comment:2 Changed 11 years ago by Olek Nowodziński

Status: assigned → review

Pushed changes to ​https://github.com/benderjs/benderjs-ckeditor/commit/4c6d8afed25d88978a032e5fa54fb7a153ffa1eb and ​branch:t/12130 (tests).

comment:3 Changed 11 years ago by Piotrek Koszuliński

Status: review → review_failed

CKEDITOR.dom.node#clone accepts a 2nd parameter - cloneId ;)

comment:4 in reply to:  3 Changed 11 years ago by Olek Nowodziński

Status: review_failed → review

Replying to Reinmar:

CKEDITOR.dom.node#clone accepts a 2nd parameter - cloneId ;)

Right. Fixed in 12130b: ​https://github.com/benderjs/benderjs-ckeditor/commit/3f1275b0b3e4e323265e0d0cf3a7ef18395e1c0d.

comment:5 Changed 11 years ago by Piotrek Koszuliński

Milestone: → CKEditor 4.4.3
Status: review → review_passed

Pushed ​branch:t/12130 rebased on master - it was incorrectly rooted in major.

comment:6 Changed 11 years ago by Olek Nowodziński

Resolution: → fixed
Status: review_passed → closed

Merged: tests ​git:05f92d4, fix ​https://github.com/benderjs/benderjs-ckeditor/commit/925e5c547545ded3f971afabbe3585416c72be16

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy