#12219 closed Bug (fixed)
[Safari] UndoManager.locked volates strict mode in undo plugin
| Reported by: | Marek Lewandowski | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.4.4 |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description (last modified by )
While working on #11739 I found out that at least these two line violates strict mode (Safari6):
The reason for that is that (at least sometimes) undoManager.locked becomes a number. And if you attempt to add new property directly to a Number object it will cause a strict violation.
Steps to repro:
- ensure that your plugins/undo/plugin.js has a use strict statement
- run plugins/undo/change test
Expected result:
Tests should pass.
Current result:
Tests test undo and test redo will fail.
additional info:
- I've pushed temp workaround for this issue to t/11739_safari_fix branch.
Change History (4)
comment:1 Changed 10 years ago by
| Summary: | UndoManager.locked volates strict mode in undo plugin → [Webkit] UndoManager.locked volates strict mode in undo plugin |
|---|
comment:2 Changed 10 years ago by
| Description: | modified (diff) |
|---|
comment:3 Changed 10 years ago by
| Milestone: | → CKEditor 4.4.4 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:4 Changed 10 years ago by
| Summary: | [Webkit] UndoManager.locked volates strict mode in undo plugin → [Safari] UndoManager.locked volates strict mode in undo plugin |
|---|
Note: See
TracTickets for help on using
tickets.
Fixed in #11739.