Opened 10 years ago

Closed 10 years ago

#1227 closed Bug (fixed)

Stop caching panel type in FCK._ActiveColorPanelType

Reported by: matthiasmiller Owned by:
Priority: Normal Milestone: FCKeditor 2.5 Beta
Component: General Version:
Keywords: Cc:

Description

Currently, when the color panel opens its popup, it caches the current color type (ForeColor vs. BackColor) in FCK._ActiveColorPanelType. Although I don't know the history of this variable, it appears that the panel type can safely be retrieved from this.Type.

This would allow other code (besides the popup) to change the selected text to a specific color.

Attachments (1)

fcktextcolorcommand.js.patch (1.2 KB) - added by matthiasmiller 10 years ago.

Download all attachments as: .zip

Change History (2)

Changed 10 years ago by matthiasmiller

comment:1 Changed 10 years ago by alfonsoml

  • Milestone set to FCKeditor 2.5
  • Resolution set to fixed
  • Status changed from new to closed

You're right, I don't see any reason to keep it.

Fixed with [828], thanks.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy