Information about aggregated tasks should be somehow accessible in aggregator#finished

[Piotrek Koszuliński]

This should be somehow possible:

notification.on( 'finished', function() {
	editor.showNotification( 'Uploaded ' + this.getDoneTasksCount() + ' files.', 'success', 2000 );
} );

The information may also be passed as evt.data's properties, but I think that this is much simpler, because we just need to move _reset() call after firing the #finished event. Note - aggregator must be reset even if the event is cancelled.

Besides that, it would be good to add this code snippet to API docs. This is so common scenario that it should be mentioned in the aggregator's class description and #finished event docs.

[Marek Lewandowski]

Pushed to ​t/12874.

[Piotr Jasiun]

I have moved tests descriptions before tests declarations, because it was misleading and suggest that this was a comment to the first line of the test code. I also added one assertion to be sure that getDoneTasksCount() returns now proper value. Closed with ​git:a191bee.

[Marek Lewandowski]

Method getDoneTasksCount is not related with _finish so it should not be included in its test.

But you've pointed out that in fact getDoneTasksCount does not have any tests.

As a result TC was added in ​git:ec874ca and revert in ​git:2f235aa840.