#12930 closed Bug (fixed)
Remove truncated-mathjax from the test directory
| Reported by: | Piotr Jasiun | Owned by: | Piotr Jasiun |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.4.8 |
| Component: | General | Version: | |
| Keywords: | Cc: | wim.leers@… |
Description
MathJax is under Apache licence which we can not use in our project so this code should be removed.
Change History (9)
comment:1 Changed 9 years ago by
| Owner: | set to Piotr Jasiun |
|---|---|
| Status: | new → assigned |
comment:2 Changed 9 years ago by
comment:3 Changed 9 years ago by
| Status: | assigned → review |
|---|
I have also introduced bender.config.mathJaxLibPath to tests so it is possible to use local mathJax. Changes in t/12930.
comment:4 Changed 9 years ago by
| Cc: | wim.leers@… added |
|---|
comment:5 Changed 9 years ago by
There should be no default configuration. Just like the CDN problem we have in the plugin code, it's not just a matter of having it configurable but to not have it hardcoded.
We must make it optional... if bender is not configured with the MathJax path the tests are ignored.
comment:6 Changed 9 years ago by
| Status: | review → review_failed |
|---|
comment:7 Changed 9 years ago by
| Status: | review_failed → review |
|---|
I removed links to the CDN from tests and added assertion with message. CDN needs to be removed also from plugin, but because it may break backward compatibility it is handled by another ticket assigned to the major release (4.5). Changes in t/12930.
comment:8 Changed 9 years ago by
| Status: | review → review_passed |
|---|
comment:9 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Closed with git:d3b2b45.
I pushed changes into master which remove MathJax and use CDN instead and merged master into major, so there is no MathJax code in the CKEditor main branches anymore.