Opened 11 years ago
Closed 10 years ago
#13207 closed Task (fixed)
Use modal window to display help in toolbar configurator
| Reported by: | Olek Nowodziński | Owned by: | Olek Nowodziński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.5.0 |
| Component: | Toolbar Configurator | Version: | 4.5.0 Beta |
| Keywords: | Cc: |
Description
Change History (7)
comment:1 Changed 11 years ago by
| Owner: | set to Olek Nowodziński |
|---|---|
| Status: | new → assigned |
comment:2 Changed 11 years ago by
| Status: | assigned → review |
|---|
comment:3 Changed 11 years ago by
| Status: | review → review_failed |
|---|
- The PicoModal license must be included - both in the samples framework and in the ckeditor-dev. If you do the 2nd point, then samples framework will be ok. In ckeditor-dev we must reorganise licenses and I'll report a separate ticket for this.
- I think that we should install PicoModal using npm in samples-framework. For many reasons such as easy upgrading, having access to source code and keeping a right license there.
comment:4 Changed 11 years ago by
I pushed one more commit to t/13207 in samples-framework and rebased t/13207 in ckeditor-dev.
comment:5 Changed 11 years ago by
Thanks R. I'll go back to this task once I'm done with high priority issues.
comment:6 Changed 11 years ago by
| Status: | review_failed → review |
|---|
Updated both branches:
- Used picomodal from npm.
- Updated SF docs.
- Updated ckeditor-dev gruntfile.
- Compiled new
sf.jsfile.
In ckeditor-dev we must reorganise licenses and I'll report a separate ticket for this.
Waiting for feedback regarding this comment.
comment:7 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
Merged to major with git:3b624b6 and to master in samples-framework: https://github.com/cksource/samples-framework/commit/965cec75c0d

Changes in branch:t/13207 and corresponding branch in samples-framework.