images fail when site path includes parentheses because background-image path in ckeditor.js needs single-quotes around url value

[Jamie]

Images (e.g. non-sprite toolbar images such as JustifyLeft, JustifyCenter, etc.) fail to display when the full site path includes parentheses (common in Visual Studio debug mode; e.g. "​http://localhost:59847/(S(tlbjdb0xrjmmgdfeuii1hhdbaf5i))/") because background-image path in ckeditor.js needs single-quotes around url value.

To fix this, find the following code in ckeditor.js:

background-image:url("+CKEDITOR.getUrl(a)+");

...and change it to...

background-image:url('"+CKEDITOR.getUrl(a)+"');

Note the added single-quotes immediately inside the parentheses. Problem solved.

[Jakub Ś]

Note the added single-quotes immediately inside the parentheses

I can see single quotes are missing from CKEditor 4.0.

[Jamie]

This bug arises on any page within an ASP.NET application that is using cookieless session state. So, it may be a very common problem. It is not limited to debug modes. (See ASP.NET configuration setting of cookieless="UseCookies | UseUri | UseDeviceProfile | AutoDetect".)

[Tomasz Jakut]

Pushed ​branch:t/13361

[Piotr Jasiun]

Code looks and works good. Well done.

Still there are some minor code style issues to fix:

• tc tag is needed only for manual tests;
• unit tag is not needed anymore, if there is no .md file test is automatically assume as "unit";
• update your comment: ticket number should be at the end in the brackets "Comment. (#13361)";
• break long lines; the line length should not be longer then 140 characters (120 is optimum).

[Tomasz Jakut]

Pushed ​branch:t/13361

• tc tag is used only in manual tests;
• unit tag deleted
• comment updated
• long lines broken

[Piotr Jasiun]

R+. Congrats :)

Changes are not merged into the master branch, because it is frozen, because of release.

I rebased branch and pushed some small changes to the ​t/13361.

[Marek Lewandowski]

Merged with ​git:e634323.