Ticket #1338 (closed Bug: worksforme)

Opened 6 years ago

Last modified 5 years ago

Avoid hardcoding border width for Gecko browsers

Reported by: matthiasmiller Owned by:
Priority: Normal Milestone:
Component: General Version:
Keywords: HasPatch Pending Cc:

Description

Gecko browsers assume that xEditingArea has a 1-pixel border. Changing this to be determined dynamically would allow greater customizability in skins (for example, a borderless editor or an editor with a beveled border).

Attachments

fckeditor.html.patch​ (534 bytes) - added by matthiasmiller 6 years ago.

Change History

Changed 6 years ago by matthiasmiller

comment:1 Changed 6 years ago by matthiasmiller

I forgot to mention: To test, I enabled the AutoGrow plugin and changed the default skin to use a different border width for xEditingArea.

comment:2 Changed 5 years ago by matthiasmiller

Is there any chance of getting this patch committed?

comment:3 Changed 5 years ago by fredck

  • Keywords HasPatch added

Marking this ticket for review.

comment:4 Changed 5 years ago by alfonsoml

I understand the reasoning, but the problem is that even without this patch I'm not able to see any bug, so I can't tell what is fixing.

Could you please provide a simple testcase or detailed instructions to see the problem (I've tried setting 0px and 10px as the border for the xEditingArea element and it seems to work fine)

comment:5 Changed 5 years ago by fredck

  • Keywords Pending added

comment:6 Changed 5 years ago by alfonsoml

  • Status changed from new to closed
  • Resolution set to worksforme

Expired.

Please reopen if you can provide the steps in order to fully test the bug and the patch.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy