No further notifications after embedbase error.

[Szymon Kupś]

1. Open ​http://tests.ckeditor.dev:1030/tests/plugins/autoembed/manual/autoembed
2. Paste non-embeddable link: ​http://example.com/
3. Wait till error notification is showed and close it.
4. Paste embeddable link: ​https://www.youtube.com/watch?v=GUl9_5kK9ts

Actual result
There are no notifications about second embedding process.

Expected result
Notifications about second embedding process should be displayed as usual.

[Szymon Kupś]

I think that problem lies in _handleResponse method in embedbase plugin. Request's task is marked there as done and later on in _handleError is marked as cancelled. This creates situation where notification aggregator works in a unexpected way.

One solution can be to call task's done() method only if response was handled correctly.

Second solution that comes to my mind is to change task behaviour: cancel() and done() methods should exclude themselves. This means that task that once was marked as done cannot be cancelled and other way around.

[Piotrek Koszuliński]

I'm more for the second solution + fixing the embedbase as well if it's easy :>. The second solution will assure that problems like this does not happen at all, also when other (e.g. 3rd party) plugins use the aggregator. The first solution would just make our code correct, which is always nice to have.

[Szymon Kupś]

Pushed ​branch:t/13566.

[Piotrek Koszuliński]

I pushed ​branch:t/13566 with some minor improvements.

The code is good. Missing things though:

1. Manual test for the reported TC.
2. A unit test for the reported TC.

[Szymon Kupś]

Pushed: ​branch:t/13566
Added unit test and manual test for the reported TC.

[Olek Nowodziński]

Rebased ​​branch:t/13566 on master.

​http://tests.ckeditor.dev:1030/tests/plugins/embedbase/definition#tests%2Fplugins%2Fembedbase%2Fdefinition%20-%20test%20canceling%20handleResponse fails (Chrome, IE8,11).

[Szymon Kupś]

Pushed: ​branch:t/13566

Test was checking if task was done after unsuccessful request. Now embedbase is cancelling tasks on request error, so test should use task.isCanceled() method.

[Olek Nowodziński]

Merged ​git:cb014cc into master.