Cannot read property 'equals' of null when trying to wrap div elements in another div.

[Wiktor Walc]

Found in Google Chrome.

1. Open ​http://ckeditor.com/demo#full
2. Start with two div elements with selection that contains a part of first and the second div:

<div  class="para">
     Some [content
</div>
<div class="note">
     This is] a note
</div>

3. Press Div button and attempt to insert a div.

Result:

Uncaught TypeError: Cannot read property 'equals' of null
createDiv @ div.js:147

[Wiktor Walc]

Note: did not check versions older than 4.0.

[Jakub Ś]

Problem can be reproduced from CKEditor 4.0 beta. In CKEditor 3.6.x editor, divs are wrapped in div.

[Tomasz Jakut]

Pushed fix to ​branch:t/13585.

[Tade0]

I managed to break something eventually. Here's how you can do the same(in Chrome):

1. Go to: ​http://tests.ckeditor.dev:1030/tests/plugins/div/manual/wrap2divsindiv
2. Select the text inside the square brackets.
3. Use the div button to insert a <div>.
4. Repeat 3. on the same selection.

The result is an error: node.js:270 Uncaught TypeError: Cannot read property 'insertBefore' of null in file core/dom/node.js

[Tomasz Jakut]

The issue was caused by the fact that sometimes groupByDivLimit returned nodes which weren't inside DOM (they didn't have parents). I added proper checks in code & pushed changes to ​branch:t/13585.

[Marek Lewandowski]

Moving tickets to the next milestone.

[Tade0]

We're going to need a unit test that specifically tests this scenario.

For now in the unit tests blockGroups[ i ].length is never zero, so this path is not covered.

[Marek Lewandowski]

Moving to 4.6.2 minor release, as 4.6.1 is mostly about polishing 4.6.0.

[Marek Lewandowski]

*t.jakut* won't be able to work on it in upcoming weeks. Let's move it into the backlog.

[Tomasz Jakut]

I've added proper unit test.

[Tade0]

The test is indeed proper.

Fixed with ​git:191a00ebe998dda70b2a6fb248f65b4647b69268.