Opened 9 years ago
Closed 9 years ago
#13603 closed Bug (fixed)
Can't embed BMP images
| Reported by: | Jonathan | Owned by: | Piotr Jasiun |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.5.3 |
| Component: | General | Version: | 4.5.0 |
| Keywords: | Cc: |
Description
Can drag and drop jpg/gif/png images into the editor, but not bmp files with imageupload plugin.
Change History (8)
comment:1 Changed 9 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 9 years ago by
I tested it on Chrome, Firefox, Safari, IE11 and IE10. The key phase is the upload preview when we show image as an element with data in the src attribute (in this case data/bmp). It works very well on all browsers expect IE10 where the preview image is small, it get the size of the text. But I believe it is not a big issue anyway so we can add BMP support.
comment:3 Changed 9 years ago by
| Owner: | set to Piotr Jasiun |
|---|---|
| Status: | confirmed → review |
Changes in t/13603.
comment:4 Changed 9 years ago by
| Milestone: | → CKEditor 4.5.3 |
|---|---|
| Version: | 4.5.1 → 4.5.0 |
comment:5 Changed 9 years ago by
On the other hand we could leave it to users and let them decide what extensions they want this plugin support by:
editor.widgets.registered.uploadimage.supportedTypes = /image\/(jpeg|png|gif|bmp)/
But to make it works supportedTypes should be read from the registered widget definition, not directly from the method parameter.
comment:6 Changed 9 years ago by
| Status: | review → review_failed |
|---|
The test passes even on master. The gif type test also checks nothing. The png type test works.
comment:8 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
Merged to master with git:e52e3b8.
We will check if it possible to handle BMP files.