Ticket #1414 (closed Bug: fixed)

Opened 7 years ago

Last modified 7 years ago

Entities inside <pre> are converted

Reported by: alfonsoml Owned by: martinkou
Priority: Normal Milestone: FCKeditor 2.5
Component: General Version: FCKeditor 2.5 Beta
Keywords: Cc:

Description

Using your browser of choice and a current nightly (it works fine in 2.4.3), switch to source mode and paste

<pre>&lt;?php echo "test"; ?&gt;</pre>

switch back to design mode and it looks fine. Go back to source mode and the entities aren't converted:

<pre>
<?php echo "test"; ?></pre>

so the code has been destroyed.

if instead of <pre> the content is inside <p> for example then it works fine.

Reported in http://www.fckeditor.net/forums/viewtopic.php?f=6&t=7246

Attachments

1414.patch (1.1 KB) - added by fredck 7 years ago.
Proposed changes to the "pre" element processor

Change History

comment:1 Changed 7 years ago by martinkou

  • Status changed from new to assigned
  • Owner set to martinkou

comment:2 Changed 7 years ago by martinkou

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [1025] and [1026].

Click here for more info about our SVN system.

Changed 7 years ago by fredck

Proposed changes to the "pre" element processor

comment:3 Changed 7 years ago by fredck

  • Priority changed from High to Normal
  • Status changed from closed to reopened
  • Resolution fixed deleted

Martin, it seams that a simpler solution can be found for it, without having to rewrite the code to handle the nodes.

I've attached a patch here. We just need to append a line break to the <pre>, so this is all that patch is doing.

Let us know if you think it is ok, based on your experience with it to fix other tickets.

comment:4 Changed 7 years ago by martinkou

  • Status changed from reopened to closed
  • Resolution set to fixed

Yes, your patch does the same thing and it's simpler. I've merged it to the trunk in [1032].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy