Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#1418 closed Bug (fixed)

FCKToolbarSet Detached Toolbar Flicker

Reported by: Scott Owned by:
Priority: Normal Milestone: FCKeditor 2.5
Component: UI : Toolbar Version: SVN (FCKeditor) - Retired
Keywords: HasPatch Cc:


When the toolbar is detached, and using the IFRAME mode, the toolbar can flicker on load as as it adjusts its size. There is a browser hack which adjusts the frame height using setTimeout() with a delay of 1 second,

I beleive the way that this is implemented could be improved.

The code is: window.onload = function () {adjust(); window.setTimeout( adjust, 1000 ); }

  • The initial call to adjust() is not needed as when it adjusts, on most browsers it adjusts to the wrong size anyway (causing flicker)
  • There does not appear to be a need for the 1000ms delay (calling it via setTimeout ensures anyway that the DOM has been fully constructed before calling the function)

I suggest that this be changed to simply:

window.setTimeout( adjust, 0 );

I have attached a patch.

Attachments (1)

patch.txt (1.2 KB) - added by Scott 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by Scott

comment:1 Changed 9 years ago by alfonsoml

That code is present to fix #272

comment:2 Changed 9 years ago by Scott

It seems like calling the adjust method via setTimeout() fixes #272 (from my testing).

My suggestion is to remove the initial adjust() which adjusts to the wrong position, and to remove the 1 second delay.

comment:3 Changed 9 years ago by alfonsoml

  • Milestone set to FCKeditor 2.5
  • Resolution set to fixed
  • Status changed from new to closed

I've tested right now (sorry for the delay) and it seems that you are right. I think that I already did test initially with a 0 delay, but I might be wrong.

Commited [1070], thank you.

comment:4 Changed 9 years ago by Scott

Thanks a lot.


Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy