Opened 8 years ago
Closed 8 years ago
#14531 closed Bug (fixed)
[Blink] Test autoparagraphing in nested editable fails
| Reported by: | Tomasz Jakut | Owned by: | Tade0 |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.5.8 |
| Component: | General | Version: | 4.5.7 |
| Keywords: | Cc: |
Description
Steps to reproduce
Expected result
Test should pass.
Actual result
Test fails. The current selection position is wrong.
Other details (browser, OS, CKEditor version, installed plugins)
Chrome 49.0.2623.87, Ubuntu 15.10
Change History (7)
comment:1 Changed 8 years ago by
| Owner: | set to Tade0 |
|---|---|
| Status: | new → assigned |
comment:2 Changed 8 years ago by
comment:3 Changed 8 years ago by
| Status: | assigned → review |
|---|
Auto paragraphing in fact does work, but in Blink it happens also on focus, which is not desired at this point.
One solution would be not to focus the editable - this is what has been implemented.
Changes pushed to branch:t/14531.
comment:4 Changed 8 years ago by
| Milestone: | CKEditor 4.5.8 → CKEditor 4.5.9 |
|---|
comment:5 Changed 8 years ago by
| Milestone: | CKEditor 4.5.9 → CKEditor 4.5.8 |
|---|
comment:6 Changed 8 years ago by
| Status: | review → review_passed |
|---|
comment:7 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
It was also enough just to put the seleciton inside text node, rather than the wrapper, and the output seleciton was fine.
Merged to master with git:bd03050.
Note: See
TracTickets for help on using
tickets.
Observation: If you insert a breakpoint anywhere before here(including at the selected line): https://github.com/ckeditor/ckeditor-dev/blob/master/tests/core/editable/domfixnestededitable.js#L41 and manually unpause after the breakpoint is reached then the test passes.