Opened 9 years ago

Closed 9 years ago

#14602 closed Bug (fixed)

Remove attributes method does not remove all attribs if no parameter is given

Reported by: Marek Lewandowski Owned by: Tomasz Jakut
Priority: Normal Milestone: CKEditor 4.5.9
Component: General Version: 4.5.9
Keywords: Cc:

Description

​Our docs for dom.removeAttributes claim:

dom.removeAttributes does not remove all attribs if no parameter is given

But in fact this method will not remove all object attribs if no argument is given.

Change History (5)

comment:1 Changed 9 years ago by Marek Lewandowski

Status: new → confirmed

comment:2 Changed 9 years ago by Tomasz Jakut

Owner: set to Tomasz Jakut
Status: confirmed → assigned

comment:3 Changed 9 years ago by Tomasz Jakut

Status: assigned → review

I've pushed proposed fix to ​branch:t/14602. I've also added getAttributes method to CKEDITOR.dom.element with tests.

comment:4 Changed 9 years ago by kkrzton

Status: review → review_passed

LGTM:) Fix works fine, all tests are passing, good docs description for a new method.

comment:5 Changed 9 years ago by Marek Lewandowski

Resolution: → fixed
Status: review_passed → closed

Fixed with ​git:e416dafb03fd9194bab1fe880030754f54b520d0 - merged to master.

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy