JS error thrown with Find and Divarea plugins used together.

[Jakub Ś]

Steps to reproduce

1. Open sample which contains Find and Divarea plugins (divrea sample in standard package).
2. Type New Paragraph added
3. Open Find dialog and search for New
4. Close the dialog with close button.

Expected result

No error is thrown.

Actual result

JS error is thrown:
Message:
Firefox: IndexSizeError: Index or size is negative or greater than the allowed amount
Chrome: IndexSizeError: Failed to execute 'setStart' on 'Range': The offset 19 is larger than or equal to the node's length (3).
Line:1933
Path: ckeditor-dev/core/selection.js

Other details (browser, OS, CKEditor version, installed plugins)

Problem can be reproduced in all browsers.

[Jakub Ś]

Based on information from user who originally reported this ticket, I have debugged this issue. It seems the problem is editor.focus(); in onHide method in find.js file.

When debuging code manually error is not thrown so a good workaround for this issue is warping editor.focus() in

CKEDITOR.tools.setTimeout( function() {
  editor.focus();
}, 0, this );

---

Still after calling editor.getSelection().selectRanges( [ range ] ); start/end offsets show 0/1 (not 03). In order to fix offsets you need to call editor.getSelection().getRanges()[0].moveToRange(range); but you should rather not be doing that in a first place so this is another workaround just for offsets.

[Tade0]

What is happening here is that when the highlight is removed the adjacent text nodes remain split even though they are adjacent.

Making sure that adjacent text nodes are merged after removing the highlight should fix this problem.

[Tade0]

Putting editor.focus() at the end seems to do the trick. I'll test this on other browsers than Chrome to see if it really works.

[Tade0]

Fix confirmed to work on IE8, IE11, Chrome, Firefox, Edge.

Added manual test.

Changes pushed to ​branch:t/14869.

[Marek Lewandowski]

Moving to 4.6.2 minor release, as 4.6.1 is mostly about polishing 4.6.0.

[Tomasz Jakut]

Current test is not failable. To correctly reproduce the issue, user must create new paragraph with at least two words in the editor that has already some content.

Tests could be also moved to other tests for "Find" plugin.

[Tade0]

Moved the test to /tests/plugins/find/manual/textnodesplit and modified the description so that the error is reproducible.

[Tomasz Jakut]

Fix seems to be working fine, the manual test is also good now. However we're still missing some unit test. It would be nice to have one to avoid regressions in the future. This should be the last part of this ticket.

[Tade0]

A unit test would be great, but designing one that would actually test something proved to be hard or perhaps impossible in this case.

[Tomasz Jakut]

Ok, so let's skip the unit test then, everything else LGTM. Fixed with ​git:35cb196.