Ticket #1502 (closed Bug: fixed)

Opened 7 years ago

Last modified 6 years ago

Remove format doesn't remove attributes

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone: FCKeditor 2.6
Component: Core : Styles Version: FCKeditor 2.5 Beta
Keywords: Confirmed Review+ Cc:

Description

The "Remove format" introduced in #75 doesn't remove any attribute, so it leaves the class and styles, so in the end the result is almost no clean up at all.

This is a list of attributes that should be cleaned at least to have some clean output:

  • class / className
  • style
  • lang
  • width
  • height
  • align
  • v:shapes
  • x:str
  • x:num
  • hspace
  • valign

Attachments

1502.patch (1.8 KB) - added by alfonsoml 6 years ago.
Proposed SVN patch
1502_2.patch (3.1 KB) - added by alfonsoml 6 years ago.
Revised patch

Change History

comment:1 Changed 6 years ago by w.olchawa

  • Keywords Confirmed added

Confirmed in IE and FF2 using version 2.5 SVN Build 18185

Changed 6 years ago by alfonsoml

Proposed SVN patch

comment:2 Changed 6 years ago by alfonsoml

  • Keywords Review? added
  • Owner set to alfonsoml
  • Status changed from new to assigned

The patch does take care of removing that list of attributes (it's configurable in fckconfig.js) when the remove Format is executed, so the output code is really clean.

Changed 6 years ago by alfonsoml

Revised patch

comment:3 Changed 6 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:4 Changed 6 years ago by alfonsoml

  • Status changed from assigned to closed
  • Resolution set to fixed
  • Milestone set to FCKeditor 2.6

Fixed with [1603]

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy