Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#1643 closed Bug (fixed)

several strict warnings

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version:
Keywords: Review+ Cc:

Description

Running with strict warnings On in Firefox shows several little problems in the console. Due to other pending changes I can't generate a clean diff to fix all of them, so this fixes just some and the others will be fixed later

Attachments (3)

1643.patch (2.0 KB) - added by alfonsoml 8 years ago.
fix for several of the warnings
1643_2.patch (4.2 KB) - added by fredck 8 years ago.
1643_3.patch (4.7 KB) - added by fredck 8 years ago.

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by alfonsoml

fix for several of the warnings

comment:1 Changed 8 years ago by alfonsoml

  • Keywords Review? added

The changes shouldn't affect the behavior at all

Changed 8 years ago by fredck

comment:2 Changed 8 years ago by fredck

Review+ for your changes Alfonso, but I was still having some warnings. I've attached a new patch, which includes also the changlog entry.

There is still one warning that I don't feel sure on how to solve it:

function eval must be called directly, and not by way of a function 
of another name
... editor/_source/fckeditorapi.js
Line 124

But I think we can live with it.

Changed 8 years ago by fredck

comment:3 Changed 8 years ago by fredck

The latest proposal includes the removal of a duplicate HasFocus in fck.js.

comment:4 Changed 8 years ago by alfonsoml

  • Keywords Review+ added; Review? removed

the third patch fixes all the main issues (maybe there are other problems after using some commands or dialogs, but they can be fixed later).

For the eval, Firefox 3 doesn't use it, instead it injects a <script> in the parent element like it's done in Safari.

comment:5 Changed 8 years ago by fredck

Fixed with [1211]. Click here for more info about our SVN system.

comment:6 Changed 8 years ago by fredck

  • Resolution set to fixed
  • Status changed from new to closed

comment:7 Changed 8 years ago by fredck

  • Milestone set to FCKeditor 2.6
Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy